2015-01-27 16:11:27

by Vladimir Kondratiev

[permalink] [raw]
Subject: [PATCH] cfg80211: fix world_regdom's n_reg_rules

In the commit:
131a19b - regulatory: enable channels 52-64 and 100-144 for world roaming

2 entries added to the world_regdom.reg_rules, while
world_regdom.n_reg_rules was not updated to reflect array size.
Fix it.

Signed-off-by: Vladimir Kondratiev <[email protected]>
---
net/wireless/reg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index b586d0d..48dfc7b 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -228,7 +228,7 @@ static DECLARE_DELAYED_WORK(reg_timeout, reg_timeout_work);

/* We keep a static world regulatory domain in case of the absence of CRDA */
static const struct ieee80211_regdomain world_regdom = {
- .n_reg_rules = 6,
+ .n_reg_rules = 8,
.alpha2 = "00",
.reg_rules = {
/* IEEE 802.11b/g, channels 1..11 */
--
2.1.0



2015-01-27 16:34:54

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] cfg80211: fix world_regdom's n_reg_rules

On Tue, 2015-01-27 at 18:10 +0200, Vladimir Kondratiev wrote:
> In the commit:
> 131a19b - regulatory: enable channels 52-64 and 100-144 for world roaming

please use 12 hex digits to refer to commits.

> 2 entries added to the world_regdom.reg_rules, while
> world_regdom.n_reg_rules was not updated to reflect array size.
> Fix it.
>
> Signed-off-by: Vladimir Kondratiev <[email protected]>

Should it be Cc stable? And you should probably add a Fixes: tag.

johannes