2015-01-28 05:57:14

by Pramod Gurav

Subject: [PATCH RESEND] ssb: Fix Sparse error in main

This change fixes below sparse error:
drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
was not declared. Should it be static?

Acked-by: Michael Buesch <[email protected]>
Signed-off-by: Pramod Gurav <[email protected]>
---
drivers/ssb/main.c | 19 -------------------
1 file changed, 19 deletions(-)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 2fead38..1e180c4 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -90,25 +90,6 @@ found:
}
#endif /* CONFIG_SSB_PCMCIAHOST */

-#ifdef CONFIG_SSB_SDIOHOST
-struct ssb_bus *ssb_sdio_func_to_bus(struct sdio_func *func)
-{
- struct ssb_bus *bus;
-
- ssb_buses_lock();
- list_for_each_entry(bus, &buses, list) {
- if (bus->bustype == SSB_BUSTYPE_SDIO &&
- bus->host_sdio == func)
- goto found;
- }
- bus = NULL;
-found:
- ssb_buses_unlock();
-
- return bus;
-}
-#endif /* CONFIG_SSB_SDIOHOST */
-
int ssb_for_each_bus_call(unsigned long data,
int (*func)(struct ssb_bus *bus, unsigned long data))
{
--
1.7.9.5

2015-01-29 08:18:46

by Kalle Valo

Subject: Re: [RESEND] ssb: Fix Sparse error in main

> This change fixes below sparse error:
> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> was not declared. Should it be static?
>
> Acked-by: Michael Buesch <[email protected]>
> Signed-off-by: Pramod Gurav <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo

2015-01-29 01:21:46

by Rafał Miłecki

Subject: Re: [PATCH RESEND] ssb: Fix Sparse error in main

On 28 January 2015 at 06:49, Pramod Gurav <[email protected]> wrote:
> This change fixes below sparse error:
> drivers/ssb/main.c:94:16: warning: symbol 'ssb_sdio_func_to_bus'
> was not declared. Should it be static?

Seems like it was never used. Looks OK.