Routine rtl_is_special_data() is supposed to identify packets that need to
use a low bit rate so that the probability of successful transmission is
high. The current version has a bug that causes all IPv6 packets to be
labelled as special, with a corresponding low rate of transmission. A
complete fix will be quite intrusive, but until that is available, all
IPv6 packets are identified as regular.
This patch also removes a magic number.
Reported-and-tested-by: Alan Fisher <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
Cc: Stable <[email protected]> [3.18+]
Cc: Alan Fisher <[email protected]>
---
drivers/net/wireless/rtlwifi/base.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/base.c b/drivers/net/wireless/rtlwifi/base.c
index 1d46774..074f716 100644
--- a/drivers/net/wireless/rtlwifi/base.c
+++ b/drivers/net/wireless/rtlwifi/base.c
@@ -1386,8 +1386,11 @@ u8 rtl_is_special_data(struct ieee80211_hw *hw, struct sk_buff *skb, u8 is_tx)
}
return true;
- } else if (0x86DD == ether_type) {
- return true;
+ } else if (ETH_P_IPV6 == ether_type) {
+ /* TODO: Handle any IPv6 cases that need special handling.
+ * For now, always return false
+ */
+ goto end;
}
end:
--
2.1.4
On 02/26/2015 06:56 AM, Kalle Valo wrote:
> Larry Finger <[email protected]> writes:
>
>> Routine rtl_is_special_data() is supposed to identify packets that need to
>> use a low bit rate so that the probability of successful transmission is
>> high. The current version has a bug that causes all IPv6 packets to be
>> labelled as special, with a corresponding low rate of transmission. A
>> complete fix will be quite intrusive, but until that is available, all
>> IPv6 packets are identified as regular.
>>
>> This patch also removes a magic number.
>>
>> Reported-and-tested-by: Alan Fisher <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>> Cc: Stable <[email protected]> [3.18+]
>> Cc: Alan Fisher <[email protected]>
>
> Should this go to 4.0?
Yes. I should have indicated that in the subject.
My expectation is that any patch that has a Cc for Stable should be applied as
soon as possible.
Larry
Larry Finger <[email protected]> writes:
> Routine rtl_is_special_data() is supposed to identify packets that need to
> use a low bit rate so that the probability of successful transmission is
> high. The current version has a bug that causes all IPv6 packets to be
> labelled as special, with a corresponding low rate of transmission. A
> complete fix will be quite intrusive, but until that is available, all
> IPv6 packets are identified as regular.
>
> This patch also removes a magic number.
>
> Reported-and-tested-by: Alan Fisher <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Stable <[email protected]> [3.18+]
> Cc: Alan Fisher <[email protected]>
Should this go to 4.0?
--
Kalle Valo
> Routine rtl_is_special_data() is supposed to identify packets that need to
> use a low bit rate so that the probability of successful transmission is
> high. The current version has a bug that causes all IPv6 packets to be
> labelled as special, with a corresponding low rate of transmission. A
> complete fix will be quite intrusive, but until that is available, all
> IPv6 packets are identified as regular.
>
> This patch also removes a magic number.
>
> Reported-and-tested-by: Alan Fisher <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>
> Cc: Stable <[email protected]> [3.18+]
> Cc: Alan Fisher <[email protected]>
Thanks, applied to wireless-drivers.git.
Kalle Valo