2015-03-26 09:59:57

by Michal Kazior

Subject: [PATCH] ath10k: clear htt.freq

If htt.freq isn't cleared and contains garbage fw
may discard tx packets. Prevent this from
happening by clearing htt.freq properly.

Possible manifestation of the problem could be not
being able to send auth request/response frames on
firmware with HTT >= 3.4 (when freq param was
introduced), e.g. on qca6174.

Fixes: 8d6d36243610 ("ath10k: fix offchan reliability")
Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 9b8313dcb888..36a244187b9c 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -2927,6 +2927,7 @@ static void ath10k_tx(struct ieee80211_hw *hw,
ath10k_dbg(ar, ATH10K_DBG_MAC, "IEEE80211_TX_CTL_NO_CCK_RATE\n");

ATH10K_SKB_CB(skb)->htt.is_offchan = false;
+ ATH10K_SKB_CB(skb)->htt.freq = 0;
ATH10K_SKB_CB(skb)->htt.tid = ath10k_tx_h_get_tid(hdr);
ATH10K_SKB_CB(skb)->vdev_id = ath10k_tx_h_get_vdev_id(ar, vif);

--
2.1.4

2015-03-30 11:59:32

by Kalle Valo

Subject: Re: [PATCH] ath10k: clear htt.freq

Michal Kazior <[email protected]> writes:

> If htt.freq isn't cleared and contains garbage fw
> may discard tx packets. Prevent this from
> happening by clearing htt.freq properly.
>
> Possible manifestation of the problem could be not
> being able to send auth request/response frames on
> firmware with HTT >= 3.4 (when freq param was
> introduced), e.g. on qca6174.
>
> Fixes: 8d6d36243610 ("ath10k: fix offchan reliability")
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied.

--
Kalle Valo