2015-05-11 16:10:56

by Vladimir Kondratiev

Subject: [PATCH v2] wil6210: fix format specifier for dma_addr_t

Fix format specifier used for dma_addr_t, namely use %pad
Debug print virtual address for the same buffer as well.

It can be applied as:
fixup! wil6210: Add pmc debug mechanism memory management

Signed-off-by: Vladimir Kondratiev <[email protected]>
---
drivers/net/wireless/ath/wil6210/pmc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/wil6210/pmc.c b/drivers/net/wireless/ath/wil6210/pmc.c
index 3cb4f35..8a8cdc6 100644
--- a/drivers/net/wireless/ath/wil6210/pmc.c
+++ b/drivers/net/wireless/ath/wil6210/pmc.c
@@ -92,9 +92,9 @@ void wil_pmc_alloc(struct wil6210_priv *wil,
GFP_KERNEL);

wil_dbg_misc(wil,
- "%s: allocated pring %p. %zd x %d = total %zd bytes\n",
+ "%s: allocated pring %p => %pad. %zd x %d = total %zd bytes\n",
__func__,
- (void *)pmc->pring_pa,
+ pmc->pring_va, &pmc->pring_pa,
sizeof(struct vring_tx_desc),
num_descriptors,
sizeof(struct vring_tx_desc) * num_descriptors);
--
2.1.0

2015-05-22 10:33:22

by Kalle Valo

Subject: Re: [PATCH v2] wil6210: fix format specifier for dma_addr_t

Vladimir Kondratiev <[email protected]> writes:

> Fix format specifier used for dma_addr_t, namely use %pad
> Debug print virtual address for the same buffer as well.
>
> It can be applied as:
> fixup! wil6210: Add pmc debug mechanism memory management
>
> Signed-off-by: Vladimir Kondratiev <[email protected]>

Thanks, applied. I just added a proper fixes line:

commit 80714b09bc574c5b23e50264e76e6e0f78d23549
Author: Vladimir Kondratiev <[email protected]>
Date: Mon May 11 19:10:48 2015 +0300

wil6210: fix format specifier for dma_addr_t

Fix format specifier used for dma_addr_t, namely use %pad
Debug print virtual address for the same buffer as well.

Fixes: dc16427bbe65 ("wil6210: Add pmc debug mechanism memory management")
Signed-off-by: Vladimir Kondratiev <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>

--
Kalle Valo