2014-06-09 09:35:30

by Dan Carpenter

Subject: re: wil6210: improve debug for WMI receive

Hello Vladimir Kondratiev,

The patch a715c7ddd65a: "wil6210: improve debug for WMI receive" from
May 29, 2014, leads to the following static checker warning:

drivers/net/wireless/ath/wil6210/wmi.c:746 wmi_recv_cmd()
info: ignoring unreachable code.

drivers/net/wireless/ath/wil6210/wmi.c
739 spin_unlock_irqrestore(&wil->wmi_ev_lock, flags);
740 {
741 int q = queue_work(wil->wmi_wq,
742 &wil->wmi_event_worker);
743 wil_dbg_wmi(wil, "queue_work -> %d\n", q);
744 }
745 }
746 if (n > 1)
^^^^^^^^^^
We never reach this if statemtent.

747 wil_dbg_wmi(wil, "%s -> %d events processed\n", __func__, n);
748 }

regards,
dan carpenter

2014-06-09 12:06:00

by Vladimir Kondratiev

Subject: Re: wil6210: improve debug for WMI receive

On Monday, June 09, 2014 12:35:18 PM Dan Carpenter wrote:
> 746 if (n > 1)
> ^^^^^^^^^^
> We never reach this if statemtent.

Dan,

Thanks for this. I'll upload fix shortly.
Caused by the missed chunk in rebase.

Thanks, Vladimir