2015-05-14 11:49:40

by Nicholas Mc Guire

Subject: [PATCH] wil6210: match wait_for_completion_timeout return type

Return type of wait_for_completion_timeout is unsigned long not int.
As remain is exclusively used for wait_for_completion_timeout here its
type is simply changed to unsigned long.


API conformance testing for completions with coccinelle spatches are being
used to locate API usage inconsistencies:
./drivers/net/wireless/ath/wil6210/wmi.c:827
int return assigned to unsigned long

Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
CONFIG_WIL6210=m

Patch is against 4.1-rc3 (localversion-next is -next-20150514)


Signed-off-by: Nicholas Mc Guire <[email protected]>
---
drivers/net/wireless/ath/wil6210/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index 9fe2085..e8d5335 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -805,7 +805,7 @@ int wmi_call(struct wil6210_priv *wil, u16 cmdid, void *buf, u16 len,
u16 reply_id, void *reply, u8 reply_size, int to_msec)
{
int rc;
- int remain;
+ unsigned long remain;

mutex_lock(&wil->wmi_mutex);

--
1.7.10.4

2015-08-17 14:43:00

by Kalle Valo

Subject: Re: [PATCH] wil6210: match wait_for_completion_timeout return type

Nicholas Mc Guire <[email protected]> writes:

> Return type of wait_for_completion_timeout is unsigned long not int.
> As remain is exclusively used for wait_for_completion_timeout here its
> type is simply changed to unsigned long.
>
>
> API conformance testing for completions with coccinelle spatches are being
> used to locate API usage inconsistencies:
> ./drivers/net/wireless/ath/wil6210/wmi.c:827
> int return assigned to unsigned long
>
> Patch was compile tested with x86_64_defconfig + CONFIG_ATH_CARDS=m,
> CONFIG_WIL6210=m
>
> Patch is against 4.1-rc3 (localversion-next is -next-20150514)
>
>
> Signed-off-by: Nicholas Mc Guire <[email protected]>

Thanks, applied to ath.git.

--
Kalle Valo