2015-06-02 08:51:28

by Felix Fietkau

Subject: [PATCH] ath9k: fix DMA stop sequence for AR9003+

AR93xx and newer needs to stop rx before tx to avoid getting the DMA
engine or MAC into a stuck state.
This should reduce/fix the occurence of "Failed to stop Tx DMA" logspam.

Cc: [email protected]
Signed-off-by: Felix Fietkau <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index d285e3a..cfd45cb 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -216,11 +216,13 @@ static bool ath_prepare_reset(struct ath_softc *sc)
ath_stop_ani(sc);
ath9k_hw_disable_interrupts(ah);

- if (!ath_drain_all_txq(sc))
- ret = false;
-
- if (!ath_stoprecv(sc))
- ret = false;
+ if (AR_SREV_9300_20_OR_LATER(ah)) {
+ ret &= ath_stoprecv(sc);
+ ret &= ath_drain_all_txq(sc);
+ } else {
+ ret &= ath_drain_all_txq(sc);
+ ret &= ath_stoprecv(sc);
+ }

return ret;
}
--
2.2.2

2015-06-08 08:40:47

by Kalle Valo

Subject: Re: ath9k: fix DMA stop sequence for AR9003+

> AR93xx and newer needs to stop rx before tx to avoid getting the DMA
> engine or MAC into a stuck state.
> This should reduce/fix the occurence of "Failed to stop Tx DMA" logspam.
>
> Cc: [email protected]
> Signed-off-by: Felix Fietkau <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo