2015-06-10 18:10:39

by Jakub Kicinski

Subject: [PATCH] mt7601u: don't warn about devices without per-rate power table

From: Jakub Kicinski <[email protected]>

We expect EEPROM per-rate power table to be filled with
s6 values and warn user if values are invalid. However,
there appear to be devices which don't have this section
of EEPROM initialized. In such case we should ignore
the values and leave the driver power tables set to zero.

Note that vendor driver doesn't care about this case but
mt76x2 skips 0xff per value. We take mt76x2's approach.

Signed-off-by: Jakub Kicinski <[email protected]>
---
Kalle, I tried my best with patchwork settings but if my name still
contains a question mark on this submission you can go ahead and
apply automatically anyway. The patch itself does not have any hairy
characters and Johannes said on IRC yesterday that pwclient ends up
doing the right thing in this case.
---
drivers/net/wireless/mediatek/mt7601u/eeprom.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/mediatek/mt7601u/eeprom.c b/drivers/net/wireless/mediatek/mt7601u/eeprom.c
index ce3837f270f0..8d8ee0344f7b 100644
--- a/drivers/net/wireless/mediatek/mt7601u/eeprom.c
+++ b/drivers/net/wireless/mediatek/mt7601u/eeprom.c
@@ -277,6 +277,10 @@ mt7601u_extra_power_over_mac(struct mt7601u_dev *dev)
static void
mt7601u_set_power_rate(struct power_per_rate *rate, s8 delta, u8 value)
{
+ /* Invalid? Note: vendor driver does not handle this */
+ if (value == 0xff)
+ return;
+
rate->raw = s6_validate(value);
rate->bw20 = s6_to_int(value);
/* Note: vendor driver does cap the value to s6 right away */
--
2.1.0

2015-06-15 09:51:43

by Kalle Valo

Subject: Re: mt7601u: don't warn about devices without per-rate power table

> From: Jakub Kicinski <[email protected]>
>
> We expect EEPROM per-rate power table to be filled with
> s6 values and warn user if values are invalid. However,
> there appear to be devices which don't have this section
> of EEPROM initialized. In such case we should ignore
> the values and leave the driver power tables set to zero.
>
> Note that vendor driver doesn't care about this case but
> mt76x2 skips 0xff per value. We take mt76x2's approach.
>
> Signed-off-by: Jakub Kicinski <[email protected]>

Thanks, applied to wireless-drivers-next.git. And your name looked correct in
git log even though I used patchwork to apply your patch.

Kalle Valo