2015-06-11 03:45:10

by Dean Lee

Subject: [PATCH] staging: wilc1000: modify odd print message

This driver has odd message in print string.
So this patch removes the data type.

Signed-off-by: Dean Lee <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 1ecb373..9e055c4 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -703,7 +703,7 @@ static WILC_Sint32 Handle_SetOperationMode(void *drvHandler, tstrHostIfSetOperat
strWID.s32ValueSize = sizeof(WILC_Uint32);

/*Sending Cfg*/
- PRINT_INFO(HOSTINF_DBG, "(size_t)pstrWFIDrv= %p \n", pstrWFIDrv);
+ PRINT_INFO(HOSTINF_DBG, "pstrWFIDrv= %p \n", pstrWFIDrv);

s32Error = SendConfigPkt(SET_CFG, &strWID, 1, WILC_TRUE, (WILC_Uint32)pstrWFIDrv);

@@ -8040,4 +8040,3 @@ WILC_Sint32 host_int_get_ipaddress(WILC_WFIDrvHandle hWFIDrv, u8 *u16ipadd, u8 i


}
-
--
2.4.3

2015-06-11 03:50:38

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wilc1000: modify odd print message

On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote:
> This driver has odd message in print string.
> So this patch removes the data type.
>
> Signed-off-by: Dean Lee <[email protected]>
> ---
> drivers/staging/wilc1000/host_interface.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 1ecb373..9e055c4 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -703,7 +703,7 @@ static WILC_Sint32 Handle_SetOperationMode(void *drvHandler, tstrHostIfSetOperat
> strWID.s32ValueSize = sizeof(WILC_Uint32);
>
> /*Sending Cfg*/
> - PRINT_INFO(HOSTINF_DBG, "(size_t)pstrWFIDrv= %p \n", pstrWFIDrv);
> + PRINT_INFO(HOSTINF_DBG, "pstrWFIDrv= %p \n", pstrWFIDrv);

Why are you printing a kernel pointer to userspace always? That's not a
good idea, why not just delete this line, how useful is it?

thanks,

greg k-h

2015-06-11 14:47:58

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: wilc1000: modify odd print message

On Thu, Jun 11, 2015 at 01:52:28PM +0900, Dean.lee wrote:
>
>
> On 2015년 06월 11일 12:50, Greg KH wrote:
> >On Thu, Jun 11, 2015 at 12:44:24PM +0900, Dean Lee wrote:
> >>This driver has odd message in print string.
> >>So this patch removes the data type.
> >>
> >>Signed-off-by: Dean Lee <[email protected]>
> >>---
> >> drivers/staging/wilc1000/host_interface.c | 3 +--
> >> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >>diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> >>index 1ecb373..9e055c4 100644
> >>--- a/drivers/staging/wilc1000/host_interface.c
> >>+++ b/drivers/staging/wilc1000/host_interface.c
> >>@@ -703,7 +703,7 @@ static WILC_Sint32 Handle_SetOperationMode(void *drvHandler, tstrHostIfSetOperat
> >> strWID.s32ValueSize = sizeof(WILC_Uint32);
> >> /*Sending Cfg*/
> >>- PRINT_INFO(HOSTINF_DBG, "(size_t)pstrWFIDrv= %p \n", pstrWFIDrv);
> >>+ PRINT_INFO(HOSTINF_DBG, "pstrWFIDrv= %p \n", pstrWFIDrv);
> >Why are you printing a kernel pointer to userspace always? That's not a
> >good idea, why not just delete this line, how useful is it?
> >
> >thanks,
> >
> >greg k-h
> we need this line for deep level debugging.
> sometime we need check and compare pointer value.

Really, even at this stage of development for the code?

> but we have plan for rework print message.
> delete unused & not required print message.

Good, all of them need to be reworked.

thanks,

greg k-h