2015-06-12 10:23:58

by Dean Lee

[permalink] [raw]
Subject: [PATCH] staging: wilc1000: update TODO list

remove complete OS wrapper functions.

Signed-off-by: Dean Lee <[email protected]>
---
drivers/staging/wilc1000/TODO | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index 95199d8..e876008 100644
--- a/drivers/staging/wilc1000/TODO
+++ b/drivers/staging/wilc1000/TODO
@@ -1,6 +1,5 @@
TODO:
- remove the defined feature as kernel versions
-- remove OS wrapper functions
- remove custom debug and tracing functions
- rework comments and function headers(also coding style)
- replace all semaphores with mutexes or completions
--
2.4.3



2015-06-12 15:27:20

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: update TODO list

On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote:
> remove complete OS wrapper functions.
>
> Signed-off-by: Dean Lee <[email protected]>
> ---
> drivers/staging/wilc1000/TODO | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
> index 95199d8..e876008 100644
> --- a/drivers/staging/wilc1000/TODO
> +++ b/drivers/staging/wilc1000/TODO
> @@ -1,6 +1,5 @@
> TODO:
> - remove the defined feature as kernel versions
> -- remove OS wrapper functions
> - remove custom debug and tracing functions
> - rework comments and function headers(also coding style)
> - replace all semaphores with mutexes or completions
> --
> 2.4.3

This isn't done yet, please make it the last patch in your series.

And are you sure you have removed them all?

thanks,

greg k-h

2015-06-12 11:07:48

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH] staging: wilc1000: update TODO list

On Fri, Jun 12, 2015 at 07:23:11PM +0900, Dean Lee wrote:
> remove complete OS wrapper functions.
just a minor thing. It will be easy if you send your patches in series
instead of separate patches. your patch "remove oswrapper & type file"
is dependent on one of the previous patch that you have sent today. If
for some reason that previous patch is not applied then
"remove oswrapper & type file" will not apply and then this patch will
have no meaning.

regards
sudip