2015-06-17 14:56:47

by Taehee Yoo

Subject: [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion".

The variable "fw_version" is used in the _ResetDigitalProcedure1().
but It is not initialized. so I add init codes for "fw_version" and
"fw_subversion".

Signed-off-by: Taehee Yoo <[email protected]>
---
V3 - Fix sparse warning.
V2 - Moved new statements into location where header is known to exist.

drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
index 29983bc..0142070 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192c/fw_common.c
@@ -240,6 +240,8 @@ int rtl92c_download_fw(struct ieee80211_hw *hw)
pfwheader->version, pfwheader->signature,
(int)sizeof(struct rtl92c_firmware_header));

+ rtlhal->fw_version = le16_to_cpu(pfwheader->version);
+ rtlhal->fw_subversion = pfwheader->subversion;
pfwdata = pfwdata + sizeof(struct rtl92c_firmware_header);
fwsize = fwsize - sizeof(struct rtl92c_firmware_header);
}
--
2.1.4

2015-07-20 15:43:33

by Kalle Valo

Subject: Re: [PATCH V3] rtlwifi: rtl8192c: Add init codes for "fw_version" and "fw_subversion".

Taehee Yoo <[email protected]> writes:

> The variable "fw_version" is used in the _ResetDigitalProcedure1().
> but It is not initialized. so I add init codes for "fw_version" and
> "fw_subversion".
>
> Signed-off-by: Taehee Yoo <[email protected]>
> ---
> V3 - Fix sparse warning.
> V2 - Moved new statements into location where header is known to exist.

I have already applied v2 and v3 won't apply anymore. What you need to
do is to create a new patch against wireless-drivers-next (on top of v2)
which fixes the sparse warning.

--
Kalle Valo