2015-07-09 13:35:21

by Thomas Petazzoni

Subject: [PATCH] net: wireless: reduce log level of CRDA related messages

With a basic Linux userspace, the messages "Calling CRDA to update
world regulatory domain" appears 10 times after boot every second or
so, followed by a final "Exceeded CRDA call max attempts. Not calling
CRDA". For those of us not having the corresponding userspace parts,
having those messages repeatedly displayed at boot time is a bit
annoying, so this commit reduces their log level to pr_debug().

Signed-off-by: Thomas Petazzoni <[email protected]>
---
net/wireless/reg.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/wireless/reg.c b/net/wireless/reg.c
index d359e06..29134c8 100644
--- a/net/wireless/reg.c
+++ b/net/wireless/reg.c
@@ -544,15 +544,15 @@ static int call_crda(const char *alpha2)
reg_regdb_query(alpha2);

if (reg_crda_timeouts > REG_MAX_CRDA_TIMEOUTS) {
- pr_info("Exceeded CRDA call max attempts. Not calling CRDA\n");
+ pr_debug("Exceeded CRDA call max attempts. Not calling CRDA\n");
return -EINVAL;
}

if (!is_world_regdom((char *) alpha2))
- pr_info("Calling CRDA for country: %c%c\n",
+ pr_debug("Calling CRDA for country: %c%c\n",
alpha2[0], alpha2[1]);
else
- pr_info("Calling CRDA to update world regulatory domain\n");
+ pr_debug("Calling CRDA to update world regulatory domain\n");

return kobject_uevent_env(&reg_pdev->dev.kobj, KOBJ_CHANGE, env);
}
--
2.4.5

2015-07-17 12:37:51

by Johannes Berg

Subject: Re: [PATCH] net: wireless: reduce log level of CRDA related messages

On Thu, 2015-07-09 at 15:35 +0200, Thomas Petazzoni wrote:
> With a basic Linux userspace, the messages "Calling CRDA to update
> world regulatory domain" appears 10 times after boot every second or
> so, followed by a final "Exceeded CRDA call max attempts. Not calling
> CRDA". For those of us not having the corresponding userspace parts,
> having those messages repeatedly displayed at boot time is a bit
> annoying, so this commit reduces their log level to pr_debug().
>
Applied.

johannes