2015-06-08 12:34:56

by Jörg Krause

[permalink] [raw]
Subject: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

Hi,

I've trouble creating the p2p interface on a BCM43362 wifi device
running Linux kernel 4.0.4:

# dmesg | grep brcmfmac
[ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware version =
wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01-b30a427d
[ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not a ISO3166
code
[ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

Trying to add the p2p interface manually:

# iw phy0 interface add p2p0 type __p2pdev
[ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC failed (-52)
[ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred
[ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid key index (4)
[ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid key index (5)

Any idea?

Best regards
Jörg Krause


2015-06-16 09:59:32

by Jörg Krause

[permalink] [raw]
Subject: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Hi Arend,

as I wrote in my previous mail ("brcmfmac: brcmf_p2p_create_p2pdev:
timeout occurred") I get a p2p0 interface when loading the brcmfmac
module with p2pon=1 (Linux kernel 4.0.5, BCM43362).

Unfortunatly, if I try to use the p2p0 interface with wpa_supplicant
2.4 I get an error:

Failed to create interface p2p-dev-p2p0: -28 (No space left on
device)
nl80211: Failed to create a P2P Device interface p2p-dev-p2p0
P2P: Failed to enable P2P Device interface

The command:

wpa_supplicant -Dnl80211 -ip2p0 -c /etc/p2p_supplicant.conf -N
-Dnl80211 -iwlan0 -c /etc/wpa_supplicant.conf -ddt &

The P2P config file:
# cat /etc/p2p_supplicant.conf
ctrl_interface=/var/run/p2p_supplicant

device_name=P2P Test
device_type=1-0050F204-1

I attached the log output from wpa_supplicant.

Best regards
Jörg Krause


Attachments:
wpa_supplicant_p2p.txt (32.11 kB)

2015-06-08 21:18:27

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

On Mo, 2015-06-08 at 23:14 +0200, Arend van Spriel wrote:
> On 06/08/15 22:17, Jörg Krause wrote:
> > On Mo, 2015-06-08 at 18:46 +0200, Arend van Spriel wrote:
> > > On 06/08/15 15:48, Jörg Krause wrote:
> > > > Hi Arend,
> > > >
> > > > On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
> > > > > On 06/08/15 14:35, Jörg Krause wrote:
> > > > > > Hi,
> > > > > >
> > > > > > I've trouble creating the p2p interface on a BCM43362 wifi
> > > > > > device
> > > > > > running Linux kernel 4.0.4:
> > > > > >
> > > > > > # dmesg | grep brcmfmac
> > > > > > [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds:
> > > > > > Firmware
> > > > > > version =
> > > > > > wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID
> > > > > > 01
> > > > > > -b30a427d
> > > > > > [ 7.158905] brcmfmac:
> > > > > > brcmf_cfg80211_reg_notifier: not
> > > > > > a
> > > > > > ISO3166
> > > > > > code
> > > > > > [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev:
> > > > > > timeout
> > > > > > occurred
> > > > > >
> > > > > > Trying to add the p2p interface manually:
> > > > > >
> > > > > > # iw phy0 interface add p2p0 type __p2pdev
> > > > > > [ 372.042704] brcmfmac: brcmf_link_down:
> > > > > > WLC_DISASSOC
> > > > > > failed
> > > > > > (-52)
> > > > > > [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev:
> > > > > > timeout
> > > > > > occurred
> > > > > > [ 373.679377] brcmfmac: brcmf_cfg80211_del_key:
> > > > > > invalid
> > > > > > key
> > > > > > index (4)
> > > > > > [ 373.685733] brcmfmac: brcmf_cfg80211_del_key:
> > > > > > invalid
> > > > > > key
> > > > > > index (5)
> > > > > >
> > > > > > Any idea?
> > > > >
> > > > > Wondering whether it is similar to what Rafal reported. Can
> > > > > you
> > > > > do a
> > > > > hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30
> > > >
> > > > I managed to set up the p2p interface by recompiling the kernel
> > > > with
> > > > CONFIG_BRCMDBG and loading the brcmfmac module with p2pon=1.
> > > >
> > > > I had a discussion some month ago with Hante Meulemann about
> > > > setting up
> > > > the p2p interface. This is one of his replies:
> > > >
> > > > "For what I can see from the log is that we don’t get the
> > > > event from
> > > > the FW indicating that the p2p interface was created.
> > > > This
> > > > probably
> > > > means that there is a bug in this FW for this device. I
> > > > need
> > > > to discuss
> > > > this to see how much priority we can give this. The best
> > > > option for you
> > > > for the moment is to use the legacy method with the
> > > > 'p2pon=1'
> > > > command."
> > >
> > > Thanks for digging your email archive as we clearly forgot about
> > > this
> > >
> > > entirely.
> >
> > Me too :-)
> >
> > > The timeout in your log indeed indicates it is missing a
> > > notification from firmware. I assume your primary interface is in
> > > managed mode when trying to create the p2p_dev interface. Is that
> > > correct?
> >
> > Correct.
>
> So do you have the following commit in your kernel tree:
>
> commit f48556e1b6a60f1b394a6c4b0a7b8cacba3eb107
> Author: Arend van Spriel <[email protected]>
> Date: Tue Sep 30 10:23:16 2014 +0200
>
> brcmfmac: assure P2P discovery is disabled when setting
> P2P_DEVICE
> mac addre
>

Yes.

$ git log --oneline --grep="brcmfmac: assure P2P discovery is disabled
when setting P2P_DEVICE"
f48556e brcmfmac: assure P2P discovery is disabled when setting
P2P_DEVICE mac address


2015-06-16 14:26:32

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

On 06/16/15 11:59, Jörg Krause wrote:
> Hi Arend,
>
> as I wrote in my previous mail ("brcmfmac: brcmf_p2p_create_p2pdev:
> timeout occurred") I get a p2p0 interface when loading the brcmfmac
> module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
>
> Unfortunatly, if I try to use the p2p0 interface with wpa_supplicant
> 2.4 I get an error:
>
> Failed to create interface p2p-dev-p2p0: -28 (No space left on
> device)
> nl80211: Failed to create a P2P Device interface p2p-dev-p2p0
> P2P: Failed to enable P2P Device interface

Using p2pon=1 is old-school p2p, ie. it creates a regular netdev for
doing p2p management stuff. Problem is that brcmfmac also indicates p2p
device support. We can remove p2pon parameter or not indicate p2p dev
support when p2pon=1.

Can you patch brcmfmac and give it a try. Need to start wpa_supplicant
for two interface and if I recall correctly p2p0 must be specified first.

Regards,
Arend

> The command:
>
> wpa_supplicant -Dnl80211 -ip2p0 -c /etc/p2p_supplicant.conf -N
> -Dnl80211 -iwlan0 -c /etc/wpa_supplicant.conf -ddt&
>
> The P2P config file:
> # cat /etc/p2p_supplicant.conf
> ctrl_interface=/var/run/p2p_supplicant
>
> device_name=P2P Test
> device_type=1-0050F204-1
>
> I attached the log output from wpa_supplicant.
>
> Best regards
> Jörg Krause


2015-06-18 06:13:42

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Hi Arend,

On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
> On 06/16/15 11:59, Jörg Krause wrote:
> > Hi Arend,
> >
> > as I wrote in my previous mail ("brcmfmac: brcmf_p2p_create_p2pdev:
> > timeout occurred") I get a p2p0 interface when loading the brcmfmac
> > module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
> >
> > Unfortunatly, if I try to use the p2p0 interface with
> > wpa_supplicant
> > 2.4 I get an error:
> >
> > Failed to create interface p2p-dev-p2p0: -28 (No space left on
> > device)
> > nl80211: Failed to create a P2P Device interface p2p-dev-p2p0
> > P2P: Failed to enable P2P Device interface
>
> Using p2pon=1 is old-school p2p, ie. it creates a regular netdev for
> doing p2p management stuff. Problem is that brcmfmac also indicates
> p2p
> device support. We can remove p2pon parameter or not indicate p2p dev
>
> support when p2pon=1.

I used p2pon because the p2p0 interface is not created without it. It
fails with the error message "brcmf_p2p_create_p2pdev: timeout
occurred" as written in my previous mails. I would prefer not to use
it, so maybe we can find a solution how to get it working without it.

>
> Can you patch brcmfmac and give it a try. Need to start
> wpa_supplicant
> for two interface and if I recall correctly p2p0 must be specified
> first.

Can you give me a hint where to patch brcmfmac. Many thanks!

Best regards
Jörg Krause

2015-06-23 11:31:27

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Hi Arend,

On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote:
>
> My bad. The patch removes p2pdev from interface modes, but it is
> still
> listed in the interface combinations and cfg80211 will complain about
> it. Have to extend the patch. I better do that after a good nights
> sleep.

Never mind! Did you had a good night sleep already :-) ?

Best regards
Jörg Krause

2015-06-08 20:16:32

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

On Mo, 2015-06-08 at 18:46 +0200, Arend van Spriel wrote:
> On 06/08/15 15:48, Jörg Krause wrote:
> > Hi Arend,
> >
> > On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
> > > On 06/08/15 14:35, Jörg Krause wrote:
> > > > Hi,
> > > >
> > > > I've trouble creating the p2p interface on a BCM43362 wifi
> > > > device
> > > > running Linux kernel 4.0.4:
> > > >
> > > > # dmesg | grep brcmfmac
> > > > [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware
> > > > version =
> > > > wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01
> > > > -b30a427d
> > > > [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not
> > > > a
> > > > ISO3166
> > > > code
> > > > [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > > > occurred
> > > >
> > > > Trying to add the p2p interface manually:
> > > >
> > > > # iw phy0 interface add p2p0 type __p2pdev
> > > > [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC
> > > > failed
> > > > (-52)
> > > > [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > > > occurred
> > > > [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid
> > > > key
> > > > index (4)
> > > > [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid
> > > > key
> > > > index (5)
> > > >
> > > > Any idea?
> > >
> > > Wondering whether it is similar to what Rafal reported. Can you
> > > do a
> > > hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30
> >
> > I managed to set up the p2p interface by recompiling the kernel
> > with
> > CONFIG_BRCMDBG and loading the brcmfmac module with p2pon=1.
> >
> > I had a discussion some month ago with Hante Meulemann about
> > setting up
> > the p2p interface. This is one of his replies:
> >
> > "For what I can see from the log is that we don’t get the
> > event from
> > the FW indicating that the p2p interface was created. This
> > probably
> > means that there is a bug in this FW for this device. I need
> > to discuss
> > this to see how much priority we can give this. The best
> > option for you
> > for the moment is to use the legacy method with the 'p2pon=1'
> > command."
>
> Thanks for digging your email archive as we clearly forgot about this
>
> entirely.

Me too :-)

> The timeout in your log indeed indicates it is missing a
> notification from firmware. I assume your primary interface is in
> managed mode when trying to create the p2p_dev interface. Is that
> correct?

Correct.

Best regards
Jörg Krause

2015-06-08 12:41:36

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

On 06/08/15 14:35, Jörg Krause wrote:
> Hi,
>
> I've trouble creating the p2p interface on a BCM43362 wifi device
> running Linux kernel 4.0.4:
>
> # dmesg | grep brcmfmac
> [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware version =
> wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01-b30a427d
> [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not a ISO3166
> code
> [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred
>
> Trying to add the p2p interface manually:
>
> # iw phy0 interface add p2p0 type __p2pdev
> [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC failed (-52)
> [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred
> [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid key index (4)
> [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid key index (5)
>
> Any idea?

Wondering whether it is similar to what Rafal reported. Can you do a
hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30

Regards,
Arend

> Best regards
> Jörg Krause


2015-06-18 08:27:53

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

On 06/18/15 08:13, Jörg Krause wrote:
> Hi Arend,
>
> On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
>> On 06/16/15 11:59, Jörg Krause wrote:
>>> Hi Arend,
>>>
>>> as I wrote in my previous mail ("brcmfmac: brcmf_p2p_create_p2pdev:
>>> timeout occurred") I get a p2p0 interface when loading the brcmfmac
>>> module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
>>>
>>> Unfortunatly, if I try to use the p2p0 interface with
>>> wpa_supplicant
>>> 2.4 I get an error:
>>>
>>> Failed to create interface p2p-dev-p2p0: -28 (No space left on
>>> device)
>>> nl80211: Failed to create a P2P Device interface p2p-dev-p2p0
>>> P2P: Failed to enable P2P Device interface
>>
>> Using p2pon=1 is old-school p2p, ie. it creates a regular netdev for
>> doing p2p management stuff. Problem is that brcmfmac also indicates
>> p2p
>> device support. We can remove p2pon parameter or not indicate p2p dev
>>
>> support when p2pon=1.
>
> I used p2pon because the p2p0 interface is not created without it. It
> fails with the error message "brcmf_p2p_create_p2pdev: timeout
> occurred" as written in my previous mails. I would prefer not to use
> it, so maybe we can find a solution how to get it working without it.

43362 firmware may have issues with regular p2p dev support so let's
stick with p2pon for now.
>>
>> Can you patch brcmfmac and give it a try. Need to start
>> wpa_supplicant
>> for two interface and if I recall correctly p2p0 must be specified
>> first.
>
> Can you give me a hint where to patch brcmfmac. Many thanks!

Attached is patch against 4.0.5 kernel.

Regards,
Arend


Attachments:
0001-brcmfmac-disable-p2pdev-support-when-using-p2pon-1.patch (1.36 kB)

2015-06-08 16:46:56

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

On 06/08/15 15:48, Jörg Krause wrote:
> Hi Arend,
>
> On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
>> On 06/08/15 14:35, Jörg Krause wrote:
>>> Hi,
>>>
>>> I've trouble creating the p2p interface on a BCM43362 wifi device
>>> running Linux kernel 4.0.4:
>>>
>>> # dmesg | grep brcmfmac
>>> [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware
>>> version =
>>> wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01
>>> -b30a427d
>>> [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not a
>>> ISO3166
>>> code
>>> [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout
>>> occurred
>>>
>>> Trying to add the p2p interface manually:
>>>
>>> # iw phy0 interface add p2p0 type __p2pdev
>>> [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC failed
>>> (-52)
>>> [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout
>>> occurred
>>> [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid key
>>> index (4)
>>> [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid key
>>> index (5)
>>>
>>> Any idea?
>>
>> Wondering whether it is similar to what Rafal reported. Can you do a
>> hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30
>
> I managed to set up the p2p interface by recompiling the kernel with
> CONFIG_BRCMDBG and loading the brcmfmac module with p2pon=1.
>
> I had a discussion some month ago with Hante Meulemann about setting up
> the p2p interface. This is one of his replies:
>
> "For what I can see from the log is that we don’t get the event from
> the FW indicating that the p2p interface was created. This probably
> means that there is a bug in this FW for this device. I need to discuss
> this to see how much priority we can give this. The best option for you
> for the moment is to use the legacy method with the 'p2pon=1' command."

Thanks for digging your email archive as we clearly forgot about this
entirely. The timeout in your log indeed indicates it is missing a
notification from firmware. I assume your primary interface is in
managed mode when trying to create the p2p_dev interface. Is that correct?

Regards,
Arend

> Best regards
> Jörg Krause


2015-06-08 13:47:20

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

Hi Arend,

On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
> On 06/08/15 14:35, Jörg Krause wrote:
> > Hi,
> >
> > I've trouble creating the p2p interface on a BCM43362 wifi device
> > running Linux kernel 4.0.4:
> >
> > # dmesg | grep brcmfmac
> > [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware
> > version =
> > wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01
> > -b30a427d
> > [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not a
> > ISO3166
> > code
> > [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > occurred
> >
> > Trying to add the p2p interface manually:
> >
> > # iw phy0 interface add p2p0 type __p2pdev
> > [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC failed
> > (-52)
> > [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > occurred
> > [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid key
> > index (4)
> > [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid key
> > index (5)
> >
> > Any idea?
>
> Wondering whether it is similar to what Rafal reported. Can you do a
> hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30

I managed to set up the p2p interface by recompiling the kernel with
CONFIG_BRCMDBG and loading the brcmfmac module with p2pon=1.

I had a discussion some month ago with Hante Meulemann about setting up
the p2p interface. This is one of his replies:

"For what I can see from the log is that we don’t get the event from
the FW indicating that the p2p interface was created. This probably
means that there is a bug in this FW for this device. I need to discuss
this to see how much priority we can give this. The best option for you
for the moment is to use the legacy method with the 'p2pon=1' command."

Best regards
Jörg Krause

2015-06-08 12:55:56

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

Hi Arend,

On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
> On 06/08/15 14:35, Jörg Krause wrote:
> > Hi,
> >
> > I've trouble creating the p2p interface on a BCM43362 wifi device
> > running Linux kernel 4.0.4:
> >
> > # dmesg | grep brcmfmac
> > [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware
> > version =
> > wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01
> > -b30a427d
> > [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not a
> > ISO3166
> > code
> > [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > occurred
> >
> > Trying to add the p2p interface manually:
> >
> > # iw phy0 interface add p2p0 type __p2pdev
> > [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC failed
> > (-52)
> > [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout
> > occurred
> > [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid key
> > index (4)
> > [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid key
> > index (5)
> >
> > Any idea?
>
> Wondering whether it is similar to what Rafal reported. Can you do a
> hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30

This is the output:

$ hexdump -C brcmfmac43362-sdio.bin | tail -30
000357e0 03 37 a2 00 02 5e 02 f0 00 a8 01 87 60 05 60 6b
|.7...^......`.`k|
000357f0 03 00 02 de 02 f0 00 00 00 68 2b eb 00 13 11 00
|.........h+.....|
00035800 b0 2c 13 00 17 a1 00 e0 5e 85 60 b7 a1 00 6b de
|.,......^.`...k.|
00035810 86 23 33 11 01 86 e0 06 f7 f7 bf 00 02 de 02 f0
|.#3.............|
00035820 00 00 00 b0 5e 8f 00 10 64 00 b0 5e 87 00 17 a3
|....^...d..^....|
00035830 00 b0 5e 8b 00 10 65 00 b0 5a 03 00 17 a1 00 68
|..^...e..Z.....h|
00035840 41 93 00 13 1a 00 02 5e 02 f0 00 a2 00 b0 40 67
|A......^......@g|
00035850 00 16 01 00 e0 41 93 00 50 64 00 b0 5a 07 00 17
|.....A..Pd..Z...|
00035860 a2 00 02 5e 02 f0 00 a8 00 e0 41 97 00 50 65 00
|...^......A..Pe.|
00035870 e8 5e 8f 00 37 a3 00 68 de 8f 00 13 15 00 02 de
|.^..7..h........|
00035880 02 f0 00 00 00 b0 5e 8f 00 10 64 00 b0 5e 87 00
|......^...d..^..|
00035890 17 a3 00 b0 5e 8b 00 10 65 00 b0 5a 03 00 17 80
|....^...e..Z....|
000358a0 00 68 41 93 00 13 28 00 02 5e 02 f0 0e 3f 00 b0
|.hA...(..^...?..|
000358b0 5e 07 00 16 01 00 e0 41 93 00 50 64 00 b0 5a 07
|^......A..Pd..Z.|
000358c0 00 17 81 00 02 5e 02 f0 0e 44 00 e0 41 97 00 50
|.....^...D..A..P|
000358d0 65 00 e8 5e 8f 00 37 a3 00 68 de 8f 00 13 23 00
|e..^..7..h....#.|
000358e0 02 de 02 f0 00 00 02 02 00 bf 00 01 88 02 03 c5
|................|
000358f0 73 00 01 b1 00 00 00 00 00 00 00 00 57 86 00 00
|s...........W...|
00035900 a5 c1 e1 42 05 5a c3 59 dc 01 75 51 3e 5b 23 49
|...B.Z.Y..uQ>[#I|
00035910 47 28 67 69 45 00 5e 55 f8 f5 c9 7d 42 0a b3 09
|G(giE.^U...}B...|
00035920 01 bd 32 08 01 00 34 33 33 36 32 61 32 2d 72 6f
|..2...43362a2-ro|
00035930 6d 6c 2f 73 64 69 6f 2d 67 2d 70 6e 6f 2d 70 6b |ml/sdio-g
-pno-pk|
00035940 74 66 69 6c 74 65 72 2d 6b 65 65 70 61 6c 69 76 |tfilter
-keepaliv|
00035950 65 2d 77 61 70 69 2d 77 6d 65 2d 70 32 70 20 56 |e-wapi-wme
-p2p V|
00035960 65 72 73 69 6f 6e 3a 20 35 2e 39 30 2e 31 39 35 |ersion:
5.90.195|
00035970 2e 38 39 20 43 52 43 3a 20 62 64 31 65 33 65 35 |.89 CRC:
bd1e3e5|
00035980 61 20 44 61 74 65 3a 20 4d 6f 6e 20 32 30 31 33 |a Date:
Mon 2013|
00035990 2d 30 34 2d 32 32 20 31 37 3a 32 34 3a 34 34 20 |-04-22
17:24:44 |
000359a0 43 53 54 7d 00 |CST}.|
000359a5

Best regards
Jörg Krause

2015-06-21 21:18:55

by Arend Van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

On 18-06-15 22:07, Jörg Krause wrote:
> On Do, 2015-06-18 at 10:27 +0200, Arend van Spriel wrote:
>> On 06/18/15 08:13, Jörg Krause wrote:
>>> Hi Arend,
>>>
>>> On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
>>>> On 06/16/15 11:59, Jörg Krause wrote:
>>>>> Hi Arend,
>>>>>
>>>>> as I wrote in my previous mail ("brcmfmac:
>>>>> brcmf_p2p_create_p2pdev:
>>>>> timeout occurred") I get a p2p0 interface when loading the
>>>>> brcmfmac
>>>>> module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
>>>>>
>>>>> Unfortunatly, if I try to use the p2p0 interface with
>>>>> wpa_supplicant
>>>>> 2.4 I get an error:
>>>>>
>>>>> Failed to create interface p2p-dev-p2p0: -28 (No space
>>>>> left on
>>>>> device)
>>>>> nl80211: Failed to create a P2P Device interface p2p-dev
>>>>> -p2p0
>>>>> P2P: Failed to enable P2P Device interface
>>>>
>>>> Using p2pon=1 is old-school p2p, ie. it creates a regular netdev
>>>> for
>>>> doing p2p management stuff. Problem is that brcmfmac also
>>>> indicates
>>>> p2p
>>>> device support. We can remove p2pon parameter or not indicate p2p
>>>> dev
>>>>
>>>> support when p2pon=1.
>>>
>>> I used p2pon because the p2p0 interface is not created without it.
>>> It
>>> fails with the error message "brcmf_p2p_create_p2pdev: timeout
>>> occurred" as written in my previous mails. I would prefer not to
>>> use
>>> it, so maybe we can find a solution how to get it working without
>>> it.
>>
>> 43362 firmware may have issues with regular p2p dev support so let's
>> stick with p2pon for now.
>
> Okay.
>
>>>>
>>>> Can you patch brcmfmac and give it a try. Need to start
>>>> wpa_supplicant
>>>> for two interface and if I recall correctly p2p0 must be
>>>> specified
>>>> first.
>>>
>>> Can you give me a hint where to patch brcmfmac. Many thanks!
>>
>> Attached is patch against 4.0.5 kernel.
>
> I applied the patch and if I load brcmfmac with p2pon=1 I get a kernel
> warning and _no_ wlan0 and p2p0 interfaces:
>
> [ 7.577223] ------------[ cut here ]------------
> [ 7.583144] WARNING: CPU: 0 PID: 4 at net/wireless/core.c:527
> wiphy_register+0x3a4/0x67c()
> [ 7.594652] Modules linked in: brcmfmac brcmutil
> [ 7.601507] CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.0.5
> -LINTECH #3
> [ 7.610809] Hardware name: Freescale MXS (Device Tree)
> [ 7.617411] Workqueue: events request_firmware_work_func
> [ 7.625110] [<c000dec8>] (unwind_backtrace) from [<c000c25c>]
> (show_stack+0x10/0x14)
> [ 7.635541] [<c000c25c>] (show_stack) from [<c001613c>]
> (warn_slowpath_common+0x78/0xb0)
> [ 7.645171] [<c001613c>] (warn_slowpath_common) from
> [<c0016210>] (warn_slowpath_null+0x1c/0x24)
> [ 7.656635] [<c0016210>] (warn_slowpath_null) from [<c03b6f20>]
> (wiphy_register+0x3a4/0x67c)
> [ 7.666657] [<c03b6f20>] (wiphy_register) from [<bf00de20>]
> (brcmf_cfg80211_attach+0x86c/0x1124 [brcmfmac])
> [ 7.679412] [<bf00de20>] (brcmf_cfg80211_attach [brcmfmac]) from
> [<bf018f3c>] (brcmf_bus_start+0xac/0x29c [brcmfmac])
> [ 7.690925] [<bf018f3c>] (brcmf_bus_start [brcmfmac]) from
> [<bf01dd00>] (brcmf_sdio_firmware_callback+0x3d8/0x9e8 [brcmfmac])
> [ 7.705622] [<bf01dd00>] (brcmf_sdio_firmware_callback
> [brcmfmac]) from [<bf0195fc>]
> (brcmf_fw_request_nvram_done+0x134/0x1d0 [brcmfmac])
> [ 7.718916] [<bf0195fc>] (brcmf_fw_request_nvram_done
> [brcmfmac]) from [<c020ab88>]
> (request_firmware_work_func+0x30/0x50)
> [ 7.733292] [<c020ab88>] (request_firmware_work_func) from
> [<c0029a98>] (process_one_work+0x184/0x418)
> [ 7.744112] [<c0029a98>] (process_one_work) from [<c002a694>]
> (worker_thread+0x3c/0x464)
> [ 7.754977] [<c002a694>] (worker_thread) from [<c002e130>]
> (kthread+0xc0/0xdc)
> [ 7.763730] [<c002e130>] (kthread) from [<c0009730>]
> (ret_from_fork+0x14/0x24)
> [ 7.773568] ---[ end trace 39ec555e61fc038e ]---
> [ 7.779710] brcmfmac: brcmf_cfg80211_attach: Could not register
> wiphy device (-22)
> [ 7.790013] brcmfmac: brcmf_bus_start: failed: -12
> [ 7.800278] brcmfmac: brcmf_sdio_firmware_callback: dongle is
> not responding

My bad. The patch removes p2pdev from interface modes, but it is still
listed in the interface combinations and cfg80211 will complain about
it. Have to extend the patch. I better do that after a good nights sleep.

Regards,
Arend

> Best regards
> Jörg Krause
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2015-06-23 12:08:36

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

On 06/23/15 13:31, Jörg Krause wrote:
> Hi Arend,
>
> On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote:
>>
>> My bad. The patch removes p2pdev from interface modes, but it is
>> still
>> listed in the interface combinations and cfg80211 will complain about
>> it. Have to extend the patch. I better do that after a good nights
>> sleep.
>
> Never mind! Did you had a good night sleep already :-) ?

Several ;-) Did not get to this earlier. Thanks for the reminder.

Had a closer look at wiphy_verify_combinations() and I am hopeful the
attached patch will fix the wiphy_register() failure.

Regards,
Arend

> Best regards
> Jörg Krause


Attachments:
0001-brcmfmac-no-p2pdev-limit-needed-when-p2pon-1-is-used.patch (1.12 kB)

2015-06-08 21:14:59

by Arend van Spriel

[permalink] [raw]
Subject: Re: brcmfmac: brcmf_p2p_create_p2pdev: timeout occurred

On 06/08/15 22:17, Jörg Krause wrote:
> On Mo, 2015-06-08 at 18:46 +0200, Arend van Spriel wrote:
>> On 06/08/15 15:48, Jörg Krause wrote:
>>> Hi Arend,
>>>
>>> On Mo, 2015-06-08 at 14:41 +0200, Arend van Spriel wrote:
>>>> On 06/08/15 14:35, Jörg Krause wrote:
>>>>> Hi,
>>>>>
>>>>> I've trouble creating the p2p interface on a BCM43362 wifi
>>>>> device
>>>>> running Linux kernel 4.0.4:
>>>>>
>>>>> # dmesg | grep brcmfmac
>>>>> [ 7.010870] brcmfmac: brcmf_c_preinit_dcmds: Firmware
>>>>> version =
>>>>> wl0: Apr 22 2013 14:50:00 version 5.90.195.89.6 FWID 01
>>>>> -b30a427d
>>>>> [ 7.158905] brcmfmac: brcmf_cfg80211_reg_notifier: not
>>>>> a
>>>>> ISO3166
>>>>> code
>>>>> [ 11.007164] brcmfmac: brcmf_p2p_create_p2pdev: timeout
>>>>> occurred
>>>>>
>>>>> Trying to add the p2p interface manually:
>>>>>
>>>>> # iw phy0 interface add p2p0 type __p2pdev
>>>>> [ 372.042704] brcmfmac: brcmf_link_down: WLC_DISASSOC
>>>>> failed
>>>>> (-52)
>>>>> [ 373.637263] brcmfmac: brcmf_p2p_create_p2pdev: timeout
>>>>> occurred
>>>>> [ 373.679377] brcmfmac: brcmf_cfg80211_del_key: invalid
>>>>> key
>>>>> index (4)
>>>>> [ 373.685733] brcmfmac: brcmf_cfg80211_del_key: invalid
>>>>> key
>>>>> index (5)
>>>>>
>>>>> Any idea?
>>>>
>>>> Wondering whether it is similar to what Rafal reported. Can you
>>>> do a
>>>> hexdump, ie. hexdump -C brcmfmac43362-sdio.bin | tail -30
>>>
>>> I managed to set up the p2p interface by recompiling the kernel
>>> with
>>> CONFIG_BRCMDBG and loading the brcmfmac module with p2pon=1.
>>>
>>> I had a discussion some month ago with Hante Meulemann about
>>> setting up
>>> the p2p interface. This is one of his replies:
>>>
>>> "For what I can see from the log is that we don’t get the
>>> event from
>>> the FW indicating that the p2p interface was created. This
>>> probably
>>> means that there is a bug in this FW for this device. I need
>>> to discuss
>>> this to see how much priority we can give this. The best
>>> option for you
>>> for the moment is to use the legacy method with the 'p2pon=1'
>>> command."
>>
>> Thanks for digging your email archive as we clearly forgot about this
>>
>> entirely.
>
> Me too :-)
>
>> The timeout in your log indeed indicates it is missing a
>> notification from firmware. I assume your primary interface is in
>> managed mode when trying to create the p2p_dev interface. Is that
>> correct?
>
> Correct.

So do you have the following commit in your kernel tree:

commit f48556e1b6a60f1b394a6c4b0a7b8cacba3eb107
Author: Arend van Spriel <[email protected]>
Date: Tue Sep 30 10:23:16 2014 +0200

brcmfmac: assure P2P discovery is disabled when setting P2P_DEVICE
mac addre

Regards,
Arend

> Best regards
> Jörg Krause
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html


2015-06-18 20:07:35

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

On Do, 2015-06-18 at 10:27 +0200, Arend van Spriel wrote:
> On 06/18/15 08:13, Jörg Krause wrote:
> > Hi Arend,
> >
> > On Di, 2015-06-16 at 16:26 +0200, Arend van Spriel wrote:
> > > On 06/16/15 11:59, Jörg Krause wrote:
> > > > Hi Arend,
> > > >
> > > > as I wrote in my previous mail ("brcmfmac:
> > > > brcmf_p2p_create_p2pdev:
> > > > timeout occurred") I get a p2p0 interface when loading the
> > > > brcmfmac
> > > > module with p2pon=1 (Linux kernel 4.0.5, BCM43362).
> > > >
> > > > Unfortunatly, if I try to use the p2p0 interface with
> > > > wpa_supplicant
> > > > 2.4 I get an error:
> > > >
> > > > Failed to create interface p2p-dev-p2p0: -28 (No space
> > > > left on
> > > > device)
> > > > nl80211: Failed to create a P2P Device interface p2p-dev
> > > > -p2p0
> > > > P2P: Failed to enable P2P Device interface
> > >
> > > Using p2pon=1 is old-school p2p, ie. it creates a regular netdev
> > > for
> > > doing p2p management stuff. Problem is that brcmfmac also
> > > indicates
> > > p2p
> > > device support. We can remove p2pon parameter or not indicate p2p
> > > dev
> > >
> > > support when p2pon=1.
> >
> > I used p2pon because the p2p0 interface is not created without it.
> > It
> > fails with the error message "brcmf_p2p_create_p2pdev: timeout
> > occurred" as written in my previous mails. I would prefer not to
> > use
> > it, so maybe we can find a solution how to get it working without
> > it.
>
> 43362 firmware may have issues with regular p2p dev support so let's
> stick with p2pon for now.

Okay.

> > >
> > > Can you patch brcmfmac and give it a try. Need to start
> > > wpa_supplicant
> > > for two interface and if I recall correctly p2p0 must be
> > > specified
> > > first.
> >
> > Can you give me a hint where to patch brcmfmac. Many thanks!
>
> Attached is patch against 4.0.5 kernel.

I applied the patch and if I load brcmfmac with p2pon=1 I get a kernel
warning and _no_ wlan0 and p2p0 interfaces:

[ 7.577223] ------------[ cut here ]------------
[ 7.583144] WARNING: CPU: 0 PID: 4 at net/wireless/core.c:527
wiphy_register+0x3a4/0x67c()
[ 7.594652] Modules linked in: brcmfmac brcmutil
[ 7.601507] CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 4.0.5
-LINTECH #3
[ 7.610809] Hardware name: Freescale MXS (Device Tree)
[ 7.617411] Workqueue: events request_firmware_work_func
[ 7.625110] [<c000dec8>] (unwind_backtrace) from [<c000c25c>]
(show_stack+0x10/0x14)
[ 7.635541] [<c000c25c>] (show_stack) from [<c001613c>]
(warn_slowpath_common+0x78/0xb0)
[ 7.645171] [<c001613c>] (warn_slowpath_common) from
[<c0016210>] (warn_slowpath_null+0x1c/0x24)
[ 7.656635] [<c0016210>] (warn_slowpath_null) from [<c03b6f20>]
(wiphy_register+0x3a4/0x67c)
[ 7.666657] [<c03b6f20>] (wiphy_register) from [<bf00de20>]
(brcmf_cfg80211_attach+0x86c/0x1124 [brcmfmac])
[ 7.679412] [<bf00de20>] (brcmf_cfg80211_attach [brcmfmac]) from
[<bf018f3c>] (brcmf_bus_start+0xac/0x29c [brcmfmac])
[ 7.690925] [<bf018f3c>] (brcmf_bus_start [brcmfmac]) from
[<bf01dd00>] (brcmf_sdio_firmware_callback+0x3d8/0x9e8 [brcmfmac])
[ 7.705622] [<bf01dd00>] (brcmf_sdio_firmware_callback
[brcmfmac]) from [<bf0195fc>]
(brcmf_fw_request_nvram_done+0x134/0x1d0 [brcmfmac])
[ 7.718916] [<bf0195fc>] (brcmf_fw_request_nvram_done
[brcmfmac]) from [<c020ab88>]
(request_firmware_work_func+0x30/0x50)
[ 7.733292] [<c020ab88>] (request_firmware_work_func) from
[<c0029a98>] (process_one_work+0x184/0x418)
[ 7.744112] [<c0029a98>] (process_one_work) from [<c002a694>]
(worker_thread+0x3c/0x464)
[ 7.754977] [<c002a694>] (worker_thread) from [<c002e130>]
(kthread+0xc0/0xdc)
[ 7.763730] [<c002e130>] (kthread) from [<c0009730>]
(ret_from_fork+0x14/0x24)
[ 7.773568] ---[ end trace 39ec555e61fc038e ]---
[ 7.779710] brcmfmac: brcmf_cfg80211_attach: Could not register
wiphy device (-22)
[ 7.790013] brcmfmac: brcmf_bus_start: failed: -12
[ 7.800278] brcmfmac: brcmf_sdio_firmware_callback: dongle is
not responding

Best regards
Jörg Krause

2015-07-07 07:47:44

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Hi Arend,

On Di, 2015-06-23 at 14:08 +0200, Arend van Spriel wrote:
> On 06/23/15 13:31, Jörg Krause wrote:
> > Hi Arend,
> >
> > On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote:
> > >
> > > My bad. The patch removes p2pdev from interface modes, but it is
> > > still
> > > listed in the interface combinations and cfg80211 will complain
> > > about
> > > it. Have to extend the patch. I better do that after a good
> > > nights
> > > sleep.
> >
> > Never mind! Did you had a good night sleep already :-) ?
>
> Several ;-) Did not get to this earlier. Thanks for the reminder.
>
> Had a closer look at wiphy_verify_combinations() and I am hopeful the
>
> attached patch will fix the wiphy_register() failure.
>

Sorry for late reply! I was busy on another topic...

I've applied your patch, but p2p interface is still not working. I
attached the debug log from wpa_supplicant.

I tested with Linux Kernel 4.0.7 and wpa_supplicant 2.4.

This is my p2p_supplicant.conf:
ctrl_interface=/var/run/p2p_supplicant
update_config=1

device_name=HBM10
device_type=1-0050F204-1

p2p_go_ht40=1

Test with the p2p_find command:
# wpa_cli -p /var/run/p2p_supplicant p2p_find
Selected interface 'p2p0'
1928.165036: p2p0: Control interface command 'P2P_FIND'
FAIL

Best regards
Jörg Krause


Attachments:
p2p.log (11.31 kB)

2015-07-23 11:06:03

by Jörg Krause

[permalink] [raw]
Subject: Re: brcmfmac: Failed to create interface p2p-dev-p2p0: -28 (No space left on device)

Hi all,

On Di, 2015-07-07 at 09:47 +0200, Jörg Krause wrote:
> Hi Arend,
>
> On Di, 2015-06-23 at 14:08 +0200, Arend van Spriel wrote:
> > On 06/23/15 13:31, Jörg Krause wrote:
> > > Hi Arend,
> > >
> > > On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote:
> > > >
> > > > My bad. The patch removes p2pdev from interface modes, but it
> > > > is
> > > > still
> > > > listed in the interface combinations and cfg80211 will complain
> > > >
> > > > about
> > > > it. Have to extend the patch. I better do that after a good
> > > > nights
> > > > sleep.
> > >
> > > Never mind! Did you had a good night sleep already :-) ?
> >
> > Several ;-) Did not get to this earlier. Thanks for the reminder.
> >
> > Had a closer look at wiphy_verify_combinations() and I am hopeful
> > the
> >
> > attached patch will fix the wiphy_register() failure.
> >
>
> Sorry for late reply! I was busy on another topic...
>
> I've applied your patch, but p2p interface is still not working. I
> attached the debug log from wpa_supplicant.
>
> I tested with Linux Kernel 4.0.7 and wpa_supplicant 2.4.
>
> This is my p2p_supplicant.conf:
> ctrl_interface=/var/run/p2p_supplicant
> update_config=1
>
> device_name=HBM10
> device_type=1-0050F204-1
>
> p2p_go_ht40=1
>
> Test with the p2p_find command:
> # wpa_cli -p /var/run/p2p_supplicant p2p_find
> Selected interface 'p2p0'
> 1928.165036: p2p0: Control interface command 'P2P_FIND'
> FAIL
>

ping :-) Any news on this?

Best regards
Jörg Krause