2015-07-31 05:39:05

by Shraddha Barke

Subject: [PATCH] Staging:wilc1000 :Remove typedef from struct

This patch fixes the following checkpatch.pl warning:

WARNING: do not add new typedefs

Signed-off-by: Shraddha Barke <[email protected]>
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 54eb8a1..d6ef6e1 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -88,7 +88,7 @@ typedef enum {
} tenuFrmSubtype;

/* Basic Frame Classes */
-typedef enum {
+enum {
CLASS1_FRAME_TYPE = 0x00,
CLASS2_FRAME_TYPE = 0x01,
CLASS3_FRAME_TYPE = 0x02,
--
2.1.0

2015-07-31 20:52:14

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging:wilc1000 :Remove typedef from struct

On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
>
> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 54eb8a1..d6ef6e1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -88,7 +88,7 @@ typedef enum {
> } tenuFrmSubtype;
>
> /* Basic Frame Classes */
> -typedef enum {
> +enum {
> CLASS1_FRAME_TYPE = 0x00,
> CLASS2_FRAME_TYPE = 0x01,
> CLASS3_FRAME_TYPE = 0x02,

Did you test-build this change?

2015-08-01 04:55:51

by Sudip Mukherjee

Subject: Re: [PATCH] Staging:wilc1000 :Remove typedef from struct

On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > This patch fixes the following checkpatch.pl warning:
> >
> > WARNING: do not add new typedefs
> >
> > Signed-off-by: Shraddha Barke <[email protected]>
> > ---
<snip>
> > -typedef enum {
> > +enum {
> > CLASS1_FRAME_TYPE = 0x00,
> > CLASS2_FRAME_TYPE = 0x01,
> > CLASS3_FRAME_TYPE = 0x02,
>
> Did you test-build this change?
This enum is not used anywhere. So did not affect the build.

regards
sudip

2015-08-01 15:55:48

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging:wilc1000 :Remove typedef from struct

On Sat, Aug 01, 2015 at 10:25:26AM +0530, Sudip Mukherjee wrote:
> On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > > This patch fixes the following checkpatch.pl warning:
> > >
> > > WARNING: do not add new typedefs
> > >
> > > Signed-off-by: Shraddha Barke <[email protected]>
> > > ---
> <snip>
> > > -typedef enum {
> > > +enum {
> > > CLASS1_FRAME_TYPE = 0x00,
> > > CLASS2_FRAME_TYPE = 0x01,
> > > CLASS3_FRAME_TYPE = 0x02,
> >
> > Did you test-build this change?
> This enum is not used anywhere. So did not affect the build.

Then it should be deleted :)