2015-08-03 08:55:04

by Michal Kazior

Subject: [PATCH] cfg80211: propagate set_wiphy failure to userspace

If driver failed to setup wiphy params (e.g. rts
threshold, fragmentation treshold) userspace
wasn't properly notified about this. This could
lead to user confusion who would think the command
succeeded even if that wasn't the case.

Signed-off-by: Michal Kazior <[email protected]>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 76b41578a838..5849fa199f77 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -2321,6 +2321,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
rdev->wiphy.frag_threshold = old_frag_threshold;
rdev->wiphy.rts_threshold = old_rts_threshold;
rdev->wiphy.coverage_class = old_coverage_class;
+ return result;
}
}
return 0;
--
2.1.4

2015-08-13 11:56:51

by Johannes Berg

Subject: Re: [PATCH] cfg80211: propagate set_wiphy failure to userspace

On Mon, 2015-08-03 at 10:55 +0200, Michal Kazior wrote:
> If driver failed to setup wiphy params (e.g. rts
> threshold, fragmentation treshold) userspace
> wasn't properly notified about this. This could
> lead to user confusion who would think the command
> succeeded even if that wasn't the case.
>
Applied.

johannes