2015-08-05 04:55:08

by Michal Kazior

Subject: [PATCH] ath10k: initialize fw_features var

If firmware did not have any feature flags set the
var would be left with values found on the stack
(i.e. garbage) yielding print string like this:

(...) features \xffffffa6m:^R\xfffffffbԂ\xffffffc4^E

Fixes: b27bc5a40f91 ("ath10k: dump fw features during probing")
Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 1a33bf04b7b7..f7aa1c73b481 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -124,7 +124,7 @@ EXPORT_SYMBOL(ath10k_info);

void ath10k_print_driver_info(struct ath10k *ar)
{
- char fw_features[128];
+ char fw_features[128] = {};

ath10k_core_get_fw_features_str(ar, fw_features, sizeof(fw_features));

--
2.1.4

2015-08-13 11:22:36

by Kalle Valo

Subject: Re: [PATCH] ath10k: initialize fw_features var

Michal Kazior <[email protected]> writes:

> If firmware did not have any feature flags set the
> var would be left with values found on the stack
> (i.e. garbage) yielding print string like this:
>
> (...) features \xffffffa6m:^R\xfffffffbԂ\xffffffc4^E
>
> Fixes: b27bc5a40f91 ("ath10k: dump fw features during probing")
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied.

--
Kalle Valo