2015-09-04 02:58:31

by Chun-Yeow Yeoh

Subject: [PATCH] mac80211: fix the setting of center freq segment 2 in VHT oper ie

This is to avoid the Channel Center Frequency Segment 2
in broadcasted VHT operation element contains the non-zero
value for non 80+80 MHz that may failed the comparison of
cfg80211_chandef_identical.

This is tested with Bob's patches related to VHT mesh support.

Signed-off-by: Chun-Yeow Yeoh <[email protected]>
---
net/mac80211/util.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/net/mac80211/util.c b/net/mac80211/util.c
index 1104421..f167056 100644
--- a/net/mac80211/util.c
+++ b/net/mac80211/util.c
@@ -2324,6 +2324,8 @@ u8 *ieee80211_ie_build_vht_oper(u8 *pos, struct ieee80211_sta_vht_cap *vht_cap,
if (chandef->center_freq2)
vht_oper->center_freq_seg2_idx =
ieee80211_frequency_to_channel(chandef->center_freq2);
+ else
+ vht_oper->center_freq_seg2_idx = 0x00;

switch (chandef->width) {
case NL80211_CHAN_WIDTH_160:
--
2.3.0

2015-09-04 05:52:21

by Johannes Berg

Subject: Re: [PATCH] mac80211: fix the setting of center freq segment 2 in VHT oper ie

On Fri, 2015-09-04 at 10:58 +0800, Chun-Yeow Yeoh wrote:
> This is to avoid the Channel Center Frequency Segment 2
> in broadcasted VHT operation element contains the non-zero
> value for non 80+80 MHz that may failed the comparison of
> cfg80211_chandef_identical.
>
> This is tested with Bob's patches related to VHT mesh support.
>
I suppose I'll squash this into the appropriate of Bob's patches :)

johannes