2015-09-19 10:47:27

by Hauke Mehrtens

Subject: [PATCH] brcmfmac: include linux/atomic.h

brcmfmac uses atomic_or() and other atomic_* functions, but does not
include linux/atomic.h. This file gets included by some other header
file so this normally does not cause problems.

Signed-off-by: Hauke Mehrtens <[email protected]>
---
drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
index f990e3d..ea9150b 100644
--- a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
@@ -15,6 +15,7 @@
*/

#include <linux/types.h>
+#include <linux/atomic.h>
#include <linux/kernel.h>
#include <linux/kthread.h>
#include <linux/printk.h>
--
2.1.4

2015-09-19 14:25:48

by Arend van Spriel

Subject: Re: [PATCH] brcmfmac: include linux/atomic.h

On 09/19/2015 12:47 PM, Hauke Mehrtens wrote:
> brcmfmac uses atomic_or() and other atomic_* functions, but does not
> include linux/atomic.h. This file gets included by some other header
> file so this normally does not cause problems.

Thanks, Hauke

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Hauke Mehrtens <[email protected]>
> ---
> drivers/net/wireless/brcm80211/brcmfmac/sdio.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> index f990e3d..ea9150b 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/sdio.c
> @@ -15,6 +15,7 @@
> */
>
> #include <linux/types.h>
> +#include <linux/atomic.h>
> #include <linux/kernel.h>
> #include <linux/kthread.h>
> #include <linux/printk.h>
>

2015-09-29 07:58:45

by Kalle Valo

Subject: Re: brcmfmac: include linux/atomic.h

> brcmfmac uses atomic_or() and other atomic_* functions, but does not
> include linux/atomic.h. This file gets included by some other header
> file so this normally does not cause problems.
>
> Signed-off-by: Hauke Mehrtens <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo