2015-10-17 20:25:39

by Paul McQuade

Subject: [PATCH] net: wireless: rt2x00: statics code style

Do not initialise statics to 0 or NULL
Also use tabs where possible

Signed-off-by: Paul McQuade <[email protected]>
---
drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
index c0e730e..53bd23d 100644
--- a/drivers/net/wireless/rt2x00/rt61pci.c
+++ b/drivers/net/wireless/rt2x00/rt61pci.c
@@ -39,7 +39,7 @@
/*
* Allow hardware encryption to be disabled.
*/
-static bool modparam_nohwcrypt = false;
+static bool modparam_nohwcrypt;
module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");

@@ -1388,7 +1388,7 @@ static bool rt61pci_get_entry_state(struct queue_entry *entry)
rt2x00_desc_read(entry_priv->desc, 0, &word);

return (rt2x00_get_field32(word, TXD_W0_OWNER_NIC) ||
- rt2x00_get_field32(word, TXD_W0_VALID));
+ rt2x00_get_field32(word, TXD_W0_VALID));
}
}

--
2.6.1

2015-10-18 13:16:23

by Sergei Shtylyov

Subject: Re: [PATCH] net: wireless: rt2x00: statics code style

Hello.

On 10/17/2015 11:25 PM, Paul McQuade wrote:

> Do not initialise statics to 0 or NULL
> Also use tabs where possible
>
> Signed-off-by: Paul McQuade <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt61pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt61pci.c b/drivers/net/wireless/rt2x00/rt61pci.c
> index c0e730e..53bd23d 100644
> --- a/drivers/net/wireless/rt2x00/rt61pci.c
> +++ b/drivers/net/wireless/rt2x00/rt61pci.c
> @@ -39,7 +39,7 @@
> /*
> * Allow hardware encryption to be disabled.
> */
> -static bool modparam_nohwcrypt = false;
> +static bool modparam_nohwcrypt;
> module_param_named(nohwcrypt, modparam_nohwcrypt, bool, S_IRUGO);
> MODULE_PARM_DESC(nohwcrypt, "Disable hardware encryption.");
>
> @@ -1388,7 +1388,7 @@ static bool rt61pci_get_entry_state(struct queue_entry *entry)
> rt2x00_desc_read(entry_priv->desc, 0, &word);
>
> return (rt2x00_get_field32(word, TXD_W0_OWNER_NIC) ||
> - rt2x00_get_field32(word, TXD_W0_VALID));
> + rt2x00_get_field32(word, TXD_W0_VALID));

This line should indented more, like it was before. And the outer parens
aren't needed.

MBR, Sergei