2015-10-19 15:30:16

by John W. Linville

Subject: [PATCH] orinoco_usb: return error in ezusb_probe when alloc_orinocodev fails

The current code exits after alloc_orinocodev, but fails to change the
return value to something that indicates the failure. This patch
changes the return value to -ENOMEM.

https://bugzilla.kernel.org/show_bug.cgi?id=106181

Signed-off-by: John W. Linville <[email protected]>
---
drivers/net/wireless/orinoco/orinoco_usb.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c b/drivers/net/wireless/orinoco/orinoco_usb.c
index 26a57d773d30..f2cd513d54b2 100644
--- a/drivers/net/wireless/orinoco/orinoco_usb.c
+++ b/drivers/net/wireless/orinoco/orinoco_usb.c
@@ -1576,6 +1576,7 @@ static int ezusb_probe(struct usb_interface *interface,
ezusb_hard_reset, NULL);
if (!priv) {
err("Couldn't allocate orinocodev");
+ retval = -ENOMEM;
goto exit;
}

--
2.4.3

2015-10-28 18:56:26

by Kalle Valo

Subject: Re: orinoco_usb: return error in ezusb_probe when alloc_orinocodev fails

> The current code exits after alloc_orinocodev, but fails to change the
> return value to something that indicates the failure. This patch
> changes the return value to -ENOMEM.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=106181
>
> Signed-off-by: John W. Linville <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo