2015-10-26 19:52:08

by punit vara

Subject: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

This patch is to the host_interface.c that fixes up following
warning by checkpatch.pl:

-Prefer eth_broadcast_addr() over memset()

Signed-off-by: Punit Vara <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 09a6c98..87b4eb8 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
msg.drv = hif_drv;

if (pu8MacAddr == NULL)
- memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
+ eth_broadcast_addr(pstrDelStationMsg->mac_addr);
else
memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);

--
2.5.3

2015-10-27 05:29:43

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: wilc1000: Fix warning prefer eth_broadcast_addr over memset()

On Tue, Oct 27, 2015 at 01:21:46AM +0530, Punit Vara wrote:
> This patch is to the host_interface.c that fixes up following
> warning by checkpatch.pl:
>
> -Prefer eth_broadcast_addr() over memset()
>
> Signed-off-by: Punit Vara <[email protected]>
> ---
> drivers/staging/wilc1000/host_interface.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 09a6c98..87b4eb8 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -4688,7 +4688,7 @@ s32 host_int_del_station(struct host_if_drv *hif_drv, const u8 *pu8MacAddr)
> msg.drv = hif_drv;
>
> if (pu8MacAddr == NULL)
> - memset(pstrDelStationMsg->mac_addr, 255, ETH_ALEN);
> + eth_broadcast_addr(pstrDelStationMsg->mac_addr);
> else
> memcpy(pstrDelStationMsg->mac_addr, pu8MacAddr, ETH_ALEN);
>

Doesn't apply to my staging.git tree at all :(