2016-02-08 13:25:30

by Felix Fietkau

Subject: [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s

reuse_skb is set to true if the code decides to use the last segment.
Fixes a memory leak

Signed-off-by: Felix Fietkau <[email protected]>
---
net/wireless/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index 6e4eb35..9880c89 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -676,7 +676,7 @@ void ieee80211_amsdu_to_8023s(struct sk_buff *skb, struct sk_buff_head *list,
u8 *payload;
int offset = 0, remaining, err;
struct ethhdr eth;
- bool reuse_skb = true;
+ bool reuse_skb = false;
bool last = false;

if (has_80211_header) {
--
2.2.2

2016-02-23 10:02:29

by Johannes Berg

Subject: Re: [PATCH] cfg80211: fix faulty variable initialization in ieee80211_amsdu_to_8023s

On Mon, 2016-02-08 at 14:25 +0100, Felix Fietkau wrote:
> reuse_skb is set to true if the code decides to use the last segment.
> Fixes a memory leak
>
Applied.

johannes