2016-03-14 23:19:36

by Marty Faltesek

Subject: [PATCH] mwifiex: fw download does not release sdio bus during failure

---
drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 4c8cae6..d6ef34f 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct mwifiex_adapter *adapter,
offset += txlen;
} while (true);

- sdio_release_host(card->func);
-
mwifiex_dbg(adapter, MSG,
"info: FW download over, size %d bytes\n", offset);

ret = 0;
done:
+ sdio_release_host(card->func);
kfree(fwbuf);
return ret;
}
--
2.7.0.rc3.207.g0ac5344

2016-03-18 08:50:22

by Amitkumar Karwar

Subject: RE: [PATCH] mwifiex: fw download does not release sdio bus during failure

> From: Marty Faltesek [mailto:[email protected]]
> Sent: Tuesday, March 15, 2016 4:49 AM
> To: Amitkumar Karwar
> Cc: [email protected]
> Subject: [PATCH] mwifiex: fw download does not release sdio bus during
> failure
>
> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c
> b/drivers/net/wireless/marvell/mwifiex/sdio.c
> index 4c8cae6..d6ef34f 100644
> --- a/drivers/net/wireless/marvell/mwifiex/sdio.c
> +++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
> @@ -1026,13 +1026,12 @@ static int mwifiex_prog_fw_w_helper(struct
> mwifiex_adapter *adapter,
> offset += txlen;
> } while (true);
>
> - sdio_release_host(card->func);
> -
> mwifiex_dbg(adapter, MSG,
> "info: FW download over, size %d bytes\n", offset);
>
> ret = 0;
> done:
> + sdio_release_host(card->func);
> kfree(fwbuf);
> return ret;
> }
> --
> 2.7.0.rc3.207.g0ac5344

Acked-by: Amitkumar Karwar <[email protected]>

Regards,
Amitkumar

2016-04-06 18:26:19

by Kalle Valo

Subject: Re: [PATCH] mwifiex: fw download does not release sdio bus during failure

Marty Faltesek <[email protected]> writes:

> ---
> drivers/net/wireless/marvell/mwifiex/sdio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Signed-off-by line is missing, please resend.

--
Kalle Valo