2016-03-18 17:15:46

by Xose Vazquez Perez

[permalink] [raw]
Subject: [PATCH] staging: refresh TODO for rtl8723au

People should not waste time and energy working on this staging driver.
A replacement(rtl8xxxu) using the kernel wireless stack already was merged
in the 4.3 kernel.

Cc: Jes Sorensen <[email protected]>
Cc: Larry Finger <[email protected]>
Cc: Kalle Valo <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Linux Driver Project Developer List <[email protected]>
Cc: Linux Wireless <[email protected]>
Signed-off-by: Xose Vazquez Perez <[email protected]>
---
drivers/staging/rtl8723au/TODO | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/staging/rtl8723au/TODO b/drivers/staging/rtl8723au/TODO
index f5d57d3..42b86e4 100644
--- a/drivers/staging/rtl8723au/TODO
+++ b/drivers/staging/rtl8723au/TODO
@@ -9,5 +9,8 @@ TODO:
- merge Realtek's bugfixes and new features into the driver
- switch to use MAC80211

+A mac80211 driver for this hardware already was integrated at
+drivers/net/wireless/realtek/rtl8xxxu/
+
Please send any patches to Greg Kroah-Hartman <[email protected]>,
Jes Sorensen <[email protected]>, and Larry Finger <[email protected]>.
--
2.5.0



2016-03-18 18:28:18

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] staging: refresh TODO for rtl8723au

On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote:
> Xose Vazquez Perez <[email protected]> writes:
> > People should not waste time and energy working on this staging driver.
> > A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> > in the 4.3 kernel.
[]
> > ?drivers/staging/rtl8723au/TODO | 3 +++
> Acked-by: Jes Sorensen <[email protected]>

why not git rm drivers/staging/rtl8723au/ ?

How about changing MAINTAINERS from:

STAGING - REALTEK RTL8723U WIRELESS DRIVER
M: Larry Finger <[email protected]>
M: Jes Sorensen <[email protected]>
L: [email protected]
S: Maintained
F: drivers/staging/rtl8723au/

to

S: Obsolete


2016-03-19 04:10:07

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] staging: refresh TODO for rtl8723au

On Fri, 2016-03-18 at 23:58 -0400, Jes Sorensen wrote:
> Joe Perches <[email protected]> writes:
> > On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote:
> > > Xose Vazquez Perez <[email protected]> writes:
> > > >
> > > > People should not waste time and energy working on this staging driver.
> > > > A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> > > > in the 4.3 kernel.
> > []
> > >
> > > >
> > > > ?drivers/staging/rtl8723au/TODO | 3 +++
> > > Acked-by: Jes Sorensen <[email protected]>
> > why not git rm drivers/staging/rtl8723au/ ?
> Because you don't just pull the rug out under people. I plan to mark it
> obsolete and then remove it in a follow-on release.

Duh.

I note you removed the obsolete suggestion which
is probably more valuable then updating the TODO.

Updating the TODO to something like:

Actual bug fixes only, no other changes accepted.
This driver is going to be removed by 4.8 or so

is also probably more valuable than keeping all the
current items and just adding a note that another
driver exists.


2016-03-19 03:58:22

by Jes Sorensen

[permalink] [raw]
Subject: Re: [PATCH] staging: refresh TODO for rtl8723au

Joe Perches <[email protected]> writes:
> On Fri, 2016-03-18 at 13:42 -0400, Jes Sorensen wrote:
>> Xose Vazquez Perez <[email protected]> writes:
>> > People should not waste time and energy working on this staging driver.
>> > A replacement(rtl8xxxu) using the kernel wireless stack already was merged
>> > in the 4.3 kernel.
> []
>> >  drivers/staging/rtl8723au/TODO | 3 +++
>> Acked-by: Jes Sorensen <[email protected]>
>
> why not git rm drivers/staging/rtl8723au/ ?

Because you don't just pull the rug out under people. I plan to mark it
obsolete and then remove it in a follow-on release.

Jes

2016-03-18 17:42:34

by Jes Sorensen

[permalink] [raw]
Subject: Re: [PATCH] staging: refresh TODO for rtl8723au

Xose Vazquez Perez <[email protected]> writes:
> People should not waste time and energy working on this staging driver.
> A replacement(rtl8xxxu) using the kernel wireless stack already was merged
> in the 4.3 kernel.
>
> Cc: Jes Sorensen <[email protected]>
> Cc: Larry Finger <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Linux Driver Project Developer List <[email protected]>
> Cc: Linux Wireless <[email protected]>
> Signed-off-by: Xose Vazquez Perez <[email protected]>
> ---
> drivers/staging/rtl8723au/TODO | 3 +++
> 1 file changed, 3 insertions(+)

Acked-by: Jes Sorensen <[email protected]>