2016-04-20 16:41:49

by Chun-Yeow Yeoh

Subject: [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled

If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
care of the crypto with software encryption/decryption
and thus, MFP can be used.

Tested for secured mesh using ath9k_htc and ath9k.

Signed-off-by: Chun-Yeow Yeoh <[email protected]>

v2: set MFP correctly (Stanislaw Gruszka)
---
drivers/net/wireless/ralink/rt2x00/rt2800lib.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
index 7fa0128..716468a 100644
--- a/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/ralink/rt2x00/rt2800lib.c
@@ -7492,6 +7492,10 @@ static int rt2800_probe_hw_mode(struct rt2x00_dev *rt2x00dev)
if (!rt2x00_is_usb(rt2x00dev))
ieee80211_hw_set(rt2x00dev->hw, HOST_BROADCAST_PS_BUFFERING);

+ /* Set MFP if HW crypto is disabled. */
+ if (rt2800_hwcrypt_disabled(rt2x00dev))
+ ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
+
SET_IEEE80211_DEV(rt2x00dev->hw, rt2x00dev->dev);
SET_IEEE80211_PERM_ADDR(rt2x00dev->hw,
rt2800_eeprom_addr(rt2x00dev,
--
2.3.0

2016-04-21 09:18:24

by Stanislaw Gruszka

Subject: Re: [PATCH v2] rt2800lib: enable MFP if hw crypt is disabled

On Thu, Apr 21, 2016 at 12:41:34AM +0800, Chun-Yeow Yeoh wrote:
> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
> care of the crypto with software encryption/decryption
> and thus, MFP can be used.
>
> Tested for secured mesh using ath9k_htc and ath9k.
>
> Signed-off-by: Chun-Yeow Yeoh <[email protected]>

Acked-by: Stanislaw Gruszka <[email protected]>

2016-04-26 09:39:59

by Kalle Valo

Subject: Re: [v2] rt2800lib: enable MFP if hw crypt is disabled

Kalle Valo <[email protected]> writes:

>> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
>> care of the crypto with software encryption/decryption
>> and thus, MFP can be used.
>>
>> Tested for secured mesh using ath9k_htc and ath9k.
>>
>> Signed-off-by: Chun-Yeow Yeoh <[email protected]>
>>
>> v2: set MFP correctly (Stanislaw Gruszka)
>> Acked-by: Stanislaw Gruszka <[email protected]>
>
> Thanks, applied to wireless-drivers-next.git.

Afterwards I edited out the change log from the commit log. Add that
after the "---" line so that git won't include it.

--
Kalle Valo

2016-04-26 09:31:25

by Kalle Valo

Subject: Re: [v2] rt2800lib: enable MFP if hw crypt is disabled

> If rt2800usb is loaded with nohwcrypt=1, mac80211 takes
> care of the crypto with software encryption/decryption
> and thus, MFP can be used.
>
> Tested for secured mesh using ath9k_htc and ath9k.
>
> Signed-off-by: Chun-Yeow Yeoh <[email protected]>
>
> v2: set MFP correctly (Stanislaw Gruszka)
> Acked-by: Stanislaw Gruszka <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo