2016-05-10 06:21:37

by Wei-Ning Huang

Subject: [PATCH] mwifiex: fixup error messages

Use dev_err instead of pr_err and add newline character at the end.

Signed-off-by: Wei-Ning Huang <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 099722e..bdc51ff 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -104,7 +104,7 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card)

if (!dev->of_node ||
!of_match_node(mwifiex_sdio_of_match_table, dev->of_node)) {
- pr_err("sdio platform data not available");
+ dev_err(dev, "sdio platform data not available\n");
return -1;
}

@@ -115,7 +115,8 @@ static int mwifiex_sdio_probe_of(struct device *dev, struct sdio_mmc_card *card)
if (cfg && card->plt_of_node) {
cfg->irq_wifi = irq_of_parse_and_map(card->plt_of_node, 0);
if (!cfg->irq_wifi) {
- dev_err(dev, "fail to parse irq_wifi from device tree");
+ dev_err(dev,
+ "fail to parse irq_wifi from device tree\n");
} else {
ret = devm_request_irq(dev, cfg->irq_wifi,
mwifiex_wake_irq_wifi,
--
2.1.2

2016-05-11 19:01:27

by Kalle Valo

Subject: Re: mwifiex: fixup error messages

Wei-Ning Huang <[email protected]> wrote:
> Use dev_err instead of pr_err and add newline character at the end.
>
> Signed-off-by: Wei-Ning Huang <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

50d4d8feb913 mwifiex: fixup error messages

--
Sent by pwcli
https://patchwork.kernel.org/patch/9054541/