2016-05-17 22:46:44

by Heinrich Schuchardt

Subject: [PATCH 1/1] rtlwifi: rtl8723be: avoid undefined behavior

Do not return undefined value for transmission power
if the rate is invalid.

Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
index 445f681..c5ca9df 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
@@ -1019,7 +1019,7 @@ static u8 _rtl8723be_get_txpower_index(struct ieee80211_hw *hw, u8 path,
struct rtl_priv *rtlpriv = rtl_priv(hw);
struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
u8 index = (channel - 1);
- u8 txpower;
+ u8 txpower = 0;
u8 power_diff_byrate = 0;

if (channel > 14 || channel < 1) {
--
2.1.4

2016-05-18 12:12:10

by Larry Finger

Subject: Re: [PATCH 1/1] rtlwifi: rtl8723be: avoid undefined behavior

On 05/17/2016 05:46 PM, Heinrich Schuchardt wrote:
> Do not return undefined value for transmission power
> if the rate is invalid.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
> index 445f681..c5ca9df 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/phy.c
> @@ -1019,7 +1019,7 @@ static u8 _rtl8723be_get_txpower_index(struct ieee80211_hw *hw, u8 path,
> struct rtl_priv *rtlpriv = rtl_priv(hw);
> struct rtl_efuse *rtlefuse = rtl_efuse(rtl_priv(hw));
> u8 index = (channel - 1);
> - u8 txpower;
> + u8 txpower = 0;
> u8 power_diff_byrate = 0;
>
> if (channel > 14 || channel < 1) {

Did gcc give you a warning about this variable not being initialized? Mine does
not. In any case, this change is appropriate.

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry

2016-06-14 14:21:00

by Kalle Valo

Subject: Re: [1/1] rtlwifi: rtl8723be: avoid undefined behavior

Heinrich Schuchardt <[email protected]> wrote:
> Do not return undefined value for transmission power
> if the rate is invalid.
>
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> Acked-by: Larry Finger <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

6b3c33e985f2 rtlwifi: rtl8723be: avoid undefined behavior

--
Sent by pwcli
https://patchwork.kernel.org/patch/9115471/