2016-07-09 01:02:31

by engineering

Subject: [PATCH] ath6kl: sme_state shortcut to SME_DISCONNECTED removed

From: Dan Kephart <[email protected]>

When an NL80211_DISCONNECT is sent to cfg80211, the driver's cfg80211
disconnect function sets the sme_state to SME_DISCONNECTED before receiving
a WMI_DISCONNECT_EVENT from the firmware. This caused cfg80211 to not know
that the connection is disconnected because the driver fails to notify
cfg80211 upon receiving WMI_DISCONNECT_EVENT from the firmware believing
it is already disconnected.

Signed-off-by: Dan Kephart <[email protected]>
---
drivers/net/wireless/ath/ath6kl/cfg80211.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/cfg80211.c b/drivers/net/wireless/ath/ath6kl/cfg80211.c
index ef5b40e..86a860f 100644
--- a/drivers/net/wireless/ath/ath6kl/cfg80211.c
+++ b/drivers/net/wireless/ath/ath6kl/cfg80211.c
@@ -847,8 +847,6 @@ static int ath6kl_cfg80211_disconnect(struct wiphy *wiphy,

up(&ar->sem);

- vif->sme_state = SME_DISCONNECTED;
-
return 0;
}

--
2.4.10

2016-07-19 17:58:54

by Kalle Valo

Subject: Re: ath6kl: sme_state shortcut to SME_DISCONNECTED removed

[email protected] wrote:
> From: Dan Kephart <[email protected]>
>
> When an NL80211_DISCONNECT is sent to cfg80211, the driver's cfg80211
> disconnect function sets the sme_state to SME_DISCONNECTED before receiving
> a WMI_DISCONNECT_EVENT from the firmware. This caused cfg80211 to not know
> that the connection is disconnected because the driver fails to notify
> cfg80211 upon receiving WMI_DISCONNECT_EVENT from the firmware believing
> it is already disconnected.
>
> Signed-off-by: Dan Kephart <[email protected]>

Thanks, 1 patch applied to ath-next branch of ath.git:

42e54152e707 ath6kl: sme_state shortcut to SME_DISCONNECTED removed

--
Sent by pwcli
https://patchwork.kernel.org/patch/9221927/