2016-08-29 08:22:36

by Baoyou Xie

Subject: [PATCH v3] brcmfmac: add missing header dependencies

We get 1 warning when biuld kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]

In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies.

Signed-off-by: Baoyou Xie <[email protected]>

---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
#ifndef __CHECKER__
#define CREATE_TRACE_POINTS
#include "tracepoint.h"
+#include "debug.h"

void __brcmf_err(const char *func, const char *fmt, ...)
{
--
2.7.4

2016-08-29 09:02:37

by Arnd Bergmann

Subject: Re: [PATCH v3] brcmfmac: add missing header dependencies

On Monday, August 29, 2016 4:14:45 PM CEST Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <[email protected]>

Acked-by: Arnd Bergmann <[email protected]>