2016-10-12 18:58:38

by Alan

Subject: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

From: Adam Williamson <[email protected]>

SDIO ID 0271:0418

Signed-off-by: Alan Cox <[email protected]>
Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921

diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
index eab0ab9..76eb336 100644
--- a/drivers/net/wireless/ath/ath6kl/sdio.c
+++ b/drivers/net/wireless/ath/ath6kl/sdio.c
@@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
{SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
+ {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
{},
};

2016-10-13 11:23:11

by Kalle Valo

Subject: Re: ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

Alan Cox <[email protected]> wrote:
> From: Adam Williamson <[email protected]>
>
> SDIO ID 0271:0418
>
> Signed-off-by: Alan Cox <[email protected]>
> Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921
> Reviewed-by: Steve deRosier <[email protected]>
>
> diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
> index eab0ab9..76eb336 100644
> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
> {},
> };
>

Patch applied to ath-current branch of ath.git, thanks.

1ea2643961b0 ath6kl: add Dell OEM SDIO I/O for the Venue 8 Pro

--
https://patchwork.kernel.org/patch/9373725/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2016-10-13 04:51:27

by Kalle Valo

Subject: Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

Steve deRosier <[email protected]> writes:

> Sorry to quibble, but the subsystem label on the commit subject line
> should be "ath6kl:" it's a lower-case "L", not a one.

Heh, I missed that :) I can fix it before I commit.

>> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
>> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
>> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
>> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
>> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
>> {},
>> };
>>
>>
>
> I see nothing wrong with this if the chip does indeed identify itself
> this way. So please fix the subject and you can add:
>
> Reviewed-by: Steve deRosier <[email protected]>

Thanks.

--
Kalle Valo

2016-10-12 21:45:25

by Steve deRosier

Subject: Re: [PATCH] ath6k1: add Dell OEM SDIO I/O for the Venue 8 Pro

Hi Alan,

Sorry to quibble, but the subsystem label on the commit subject line
should be "ath6kl:" it's a lower-case "L", not a one.


On Wed, Oct 12, 2016 at 11:08 AM, Alan <[email protected]> wrote:
> From: Adam Williamson <[email protected]>
>
> SDIO ID 0271:0418
>
> Signed-off-by: Alan Cox <[email protected]>
> Bugzilla-ID: https://bugzilla.kernel.org/show_bug.cgi?id=67921
>
> diff --git a/drivers/net/wireless/ath/ath6kl/sdio.c b/drivers/net/wireless/ath/ath6kl/sdio.c
> index eab0ab9..76eb336 100644
> --- a/drivers/net/wireless/ath/ath6kl/sdio.c
> +++ b/drivers/net/wireless/ath/ath6kl/sdio.c
> @@ -1401,6 +1401,7 @@ static const struct sdio_device_id ath6kl_sdio_devices[] = {
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x0))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x1))},
> {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x2))},
> + {SDIO_DEVICE(MANUFACTURER_CODE, (MANUFACTURER_ID_AR6004_BASE | 0x18))},
> {},
> };
>
>

I see nothing wrong with this if the chip does indeed identify itself
this way. So please fix the subject and you can add:

Reviewed-by: Steve deRosier <[email protected]>

- Steve