2017-02-03 13:00:45

by Amitkumar Karwar

Subject: [PATCH] mwifiex: Avoid skipping WEP key deletion for AP

From: Ganapathi Bhat <[email protected]>

This patch fixes the issue specific to AP. AP is started with WEP
security and external station is connected to it. Data path works
in this case. Now if AP is restarted with WPA/WPA2 security,
station is able to connect but ping fails.

Driver skips the deletion of WEP keys if interface type is AP.
Removing that redundant check resolves the issue.

Fixes: e57f1734("mwifiex: add key material v2 support")
Signed-off-by: Ganapathi Bhat <[email protected]>
Signed-off-by: Amitkumar Karwar <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/sta_ioctl.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
index 644f3a2..1532ac9 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_ioctl.c
@@ -1159,8 +1159,6 @@ int mwifiex_set_encode(struct mwifiex_private *priv, struct key_params *kp,
encrypt_key.is_rx_seq_valid = true;
}
} else {
- if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_UAP)
- return 0;
encrypt_key.key_disable = true;
if (mac_addr)
memcpy(encrypt_key.mac_addr, mac_addr, ETH_ALEN);
--
1.9.1

2017-02-07 08:03:59

by Kalle Valo

Subject: Re: mwifiex: Avoid skipping WEP key deletion for AP

Amitkumar Karwar <[email protected]> wrote:
> From: Ganapathi Bhat <[email protected]>
>
> This patch fixes the issue specific to AP. AP is started with WEP
> security and external station is connected to it. Data path works
> in this case. Now if AP is restarted with WPA/WPA2 security,
> station is able to connect but ping fails.
>
> Driver skips the deletion of WEP keys if interface type is AP.
> Removing that redundant check resolves the issue.
>
> Fixes: e57f1734d87a ("mwifiex: add key material v2 support")
> Signed-off-by: Ganapathi Bhat <[email protected]>
> Signed-off-by: Amitkumar Karwar <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

a5b60de6972d mwifiex: Avoid skipping WEP key deletion for AP

--
https://patchwork.kernel.org/patch/9554057/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches