2017-04-04 04:49:01

by Ganapathi Bhat

Subject: [PATCH] mwifiex: Fix invalid port issue

We have to use start port, for TX/RX of single packet,
instead of current aggregating port. This will fix SDIO
CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.

fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet')
Signed-off-by: Ganapathi Bhat <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 58d3da0..369450a 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1380,7 +1380,7 @@ static int mwifiex_sdio_card_to_host_mp_aggr(struct mwifiex_adapter *adapter,
}

if (card->mpa_rx.pkt_cnt == 1)
- mport = adapter->ioport + port;
+ mport = adapter->ioport + card->mpa_rx.start_port;

if (mwifiex_read_data_sync(adapter, card->mpa_rx.buf,
card->mpa_rx.buf_len, mport, 1))
@@ -1813,7 +1813,7 @@ static int mwifiex_host_to_card_mp_aggr(struct mwifiex_adapter *adapter,
}

if (card->mpa_tx.pkt_cnt == 1)
- mport = adapter->ioport + port;
+ mport = adapter->ioport + card->mpa_tx.start_port;

ret = mwifiex_write_data_to_card(adapter, card->mpa_tx.buf,
card->mpa_tx.buf_len, mport);
--
1.9.1

2017-04-05 10:52:13

by Kalle Valo

Subject: Re: mwifiex: Fix invalid port issue

Ganapathi Bhat <[email protected]> wrote:
> We have to use start port, for TX/RX of single packet,
> instead of current aggregating port. This will fix SDIO
> CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.
>
> fixes: 0cb52aac4 ('mwifiex: do not set multiport flag for tx/rx single packet')
> Signed-off-by: Ganapathi Bhat <[email protected]>

The correct format is:

Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet")

I can fix that. (no pun intended)

--
https://patchwork.kernel.org/patch/9660845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-04-13 14:05:48

by Kalle Valo

Subject: Re: mwifiex: Fix invalid port issue

Ganapathi Bhat <[email protected]> wrote:
> We have to use start port, for TX/RX of single packet,
> instead of current aggregating port. This will fix SDIO
> CMD53(TX/RX) returning -ETIMEDOUT and halting the data path.
>
> Fixes: 0cb52aac4d19 ("mwifiex: do not set multiport flag for tx/rx single packet")
> Signed-off-by: Ganapathi Bhat <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

ecd7eb7c2bcf mwifiex: Fix invalid port issue

--
https://patchwork.kernel.org/patch/9660845/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches