2017-04-04 16:49:43

by Mohammed Shafi Shajakhan (Mohammed Shafi)

Subject: [PATCH] ath10k: Fix compile time sanity check for CE4 buffer size

From: Mohammed Shafi Shajakhan <[email protected]>

In 'ath10k_ce_alloc_pipe' the compile time sanity check to
ensure that there is sufficient buffers in CE4 for HTT Tx
MSDU descriptors, but this did not take into account of the
case with 'peer flow control' enabled, fix this.

Cc: Michal Kazior <[email protected]>
Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
[thanks to Michal for the suggestion]

drivers/net/wireless/ath/ath10k/ce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/ce.c b/drivers/net/wireless/ath/ath10k/ce.c
index 9ac0a73..ee1090c 100644
--- a/drivers/net/wireless/ath/ath10k/ce.c
+++ b/drivers/net/wireless/ath/ath10k/ce.c
@@ -1051,7 +1051,7 @@ int ath10k_ce_alloc_pipe(struct ath10k *ar, int ce_id,
*/
BUILD_BUG_ON(2 * TARGET_NUM_MSDU_DESC >
(CE_HTT_H2T_MSG_SRC_NENTRIES - 1));
- BUILD_BUG_ON(2 * TARGET_10X_NUM_MSDU_DESC >
+ BUILD_BUG_ON(2 * TARGET_10_4_NUM_MSDU_DESC_PFC >
(CE_HTT_H2T_MSG_SRC_NENTRIES - 1));
BUILD_BUG_ON(2 * TARGET_TLV_NUM_MSDU_DESC >
(CE_HTT_H2T_MSG_SRC_NENTRIES - 1));
--
1.9.1

2017-04-13 12:45:10

by Kalle Valo

Subject: Re: ath10k: Fix compile time sanity check for CE4 buffer size

Mohammed Shafi Shajakhan <[email protected]> wrote:
> From: Mohammed Shafi Shajakhan <[email protected]>
>
> In 'ath10k_ce_alloc_pipe' the compile time sanity check to
> ensure that there is sufficient buffers in CE4 for HTT Tx
> MSDU descriptors, but this did not take into account of the
> case with 'peer flow control' enabled, fix this.
>
> Cc: Michal Kazior <[email protected]>
> Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

62ca0690cd49 ath10k: fix compile time sanity check for CE4 buffer size

--
https://patchwork.kernel.org/patch/9662059/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches