2017-08-23 09:59:54

by Arvind Yadav

Subject: [PATCH 0/3] constify *_ops

*_ops are not supposed to change at runtime and none of the structures
is modified.

Arvind Yadav (3):
[PATCH 1/3] net: rtlwifi: constify rate_control_ops
[PATCH 2/3] net: rsi: mac80211: constify ieee80211_ops
[PATCH 3/3] net: rsi: netlink: constify genl_ops

drivers/net/wireless/realtek/rtlwifi/rc.c | 2 +-
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +-
net/tipc/netlink_compat.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

--
1.9.1

2017-08-23 09:59:58

by Arvind Yadav

Subject: [PATCH 1/3] net: rtlwifi: constify rate_control_ops

rate_control_ops are not supposed to change at runtime. All functions
working with rate_control_ops provided by <net/mac80211.h> work with
const rate_control_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rc.c b/drivers/net/wireless/realtek/rtlwifi/rc.c
index 951d257..02811ed 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rc.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rc.c
@@ -283,7 +283,7 @@ static void rtl_rate_free_sta(void *rtlpriv,
kfree(rate_priv);
}

-static struct rate_control_ops rtl_rate_ops = {
+static const struct rate_control_ops rtl_rate_ops = {
.name = "rtl_rc",
.alloc = rtl_rate_alloc,
.free = rtl_rate_free,
--
1.9.1

2017-08-24 09:57:48

by Kalle Valo

Subject: Re: [1/3] net: rtlwifi: constify rate_control_ops

Arvind Yadav <[email protected]> wrote:

> rate_control_ops are not supposed to change at runtime. All functions
> working with rate_control_ops provided by <net/mac80211.h> work with
> const rate_control_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

2 patches applied to wireless-drivers-next.git, thanks.

28b75415ad19 wireless: ipw2200: Replace PCI pool old API
9ea792a48cdd net: rsi: mac80211: constify ieee80211_ops

--
https://patchwork.kernel.org/patch/9917001/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-08-23 10:02:58

by Kalle Valo

Subject: Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

Arvind Yadav <[email protected]> writes:

> genl_ops are not supposed to change at runtime. All functions
> working with genl_ops provided by <net/genetlink.h> work with
> const genl_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> net/tipc/netlink_compat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Using the prefix "rsi:" looks wrong for this patch.

--
Kalle Valo

2017-08-23 10:05:25

by Arvind Yadav

Subject: Re: [PATCH 3/3] net: rsi: netlink: constify genl_ops

Hi,


On Wednesday 23 August 2017 03:32 PM, Kalle Valo wrote:
> Arvind Yadav <[email protected]> writes:
>
>> genl_ops are not supposed to change at runtime. All functions
>> working with genl_ops provided by <net/genetlink.h> work with
>> const genl_ops. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <[email protected]>
>> ---
>> net/tipc/netlink_compat.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
> Using the prefix "rsi:" looks wrong for this patch.
Thanks for pointing. I will update.
>
~arvind

2017-08-23 10:00:02

by Arvind Yadav

Subject: [PATCH 2/3] net: rsi: mac80211: constify ieee80211_ops

ieee80211_ops are not supposed to change at runtime. All functions
working with ieee80211_ops provided by <net/mac80211.h> work with
const ieee80211_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 021e5ac..67532fb 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -1177,7 +1177,7 @@ static void rsi_reg_notify(struct wiphy *wiphy,
adapter->dfs_region = request->dfs_region;
}

-static struct ieee80211_ops mac80211_ops = {
+static const struct ieee80211_ops mac80211_ops = {
.tx = rsi_mac80211_tx,
.start = rsi_mac80211_start,
.stop = rsi_mac80211_stop,
--
1.9.1

2017-08-23 10:00:06

by Arvind Yadav

Subject: [PATCH 3/3] net: rsi: netlink: constify genl_ops

genl_ops are not supposed to change at runtime. All functions
working with genl_ops provided by <net/genetlink.h> work with
const genl_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
net/tipc/netlink_compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/tipc/netlink_compat.c b/net/tipc/netlink_compat.c
index 750949d..e48f0b2 100644
--- a/net/tipc/netlink_compat.c
+++ b/net/tipc/netlink_compat.c
@@ -1217,7 +1217,7 @@ static int tipc_nl_compat_recv(struct sk_buff *skb, struct genl_info *info)
return err;
}

-static struct genl_ops tipc_genl_compat_ops[] = {
+static const struct genl_ops tipc_genl_compat_ops[] = {
{
.cmd = TIPC_GENL_CMD,
.doit = tipc_nl_compat_recv,
--
1.9.1