2017-09-23 10:37:10

by Christoph Böhmwalder

Subject: [PATCH] wireless: iwlwifi: fix minor code style issues

Fixes three trivial issues as reported by checkpatch.pl, namely two
switch/case indentation issues and one alignment issue in a multiline comment.

Signed-off-by: Christoph Böhmwalder <[email protected]>
---
drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
index 99676d6c4713..ccdb247d68c5 100644
--- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
@@ -832,7 +832,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
capa->standard_phy_calibration_size =
le32_to_cpup((__le32 *)tlv_data);
break;
- case IWL_UCODE_TLV_SEC_RT:
+ case IWL_UCODE_TLV_SEC_RT:
iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR,
tlv_len);
drv->fw.type = IWL_FW_MVM;
@@ -864,7 +864,7 @@ static int iwl_parse_tlv_firmware(struct iwl_drv *drv,
FW_PHY_CFG_RX_CHAIN) >>
FW_PHY_CFG_RX_CHAIN_POS;
break;
- case IWL_UCODE_TLV_SECURE_SEC_RT:
+ case IWL_UCODE_TLV_SECURE_SEC_RT:
iwl_store_ucode_sec(pieces, tlv_data, IWL_UCODE_REGULAR,
tlv_len);
drv->fw.type = IWL_FW_MVM;
@@ -1335,7 +1335,8 @@ static void iwl_req_fw_callback(const struct firmware *ucode_raw, void *context)

/* Runtime instructions and 2 copies of data:
* 1) unmodified from disk
- * 2) backup cache for save/restore during power-downs */
+ * 2) backup cache for save/restore during power-downs
+ */
for (i = 0; i < IWL_UCODE_TYPE_MAX; i++)
if (iwl_alloc_ucode(drv, pieces, i))
goto out_free_fw;
--
2.13.5

2017-09-25 13:16:43

by Luciano Coelho

Subject: Re: [PATCH] wireless: iwlwifi: fix minor code style issues

T24gU2F0LCAyMDE3LTA5LTIzIGF0IDEyOjMxICswMjAwLCBDaHJpc3RvcGggQsO2aG13YWxkZXIg
d3JvdGU6DQo+IEZpeGVzIHRocmVlIHRyaXZpYWwgaXNzdWVzIGFzIHJlcG9ydGVkIGJ5IGNoZWNr
cGF0Y2gucGwsIG5hbWVseSB0d28NCj4gc3dpdGNoL2Nhc2UgaW5kZW50YXRpb24gaXNzdWVzIGFu
ZCBvbmUgYWxpZ25tZW50IGlzc3VlIGluIGEgbXVsdGlsaW5lIGNvbW1lbnQuDQo+IA0KPiBTaWdu
ZWQtb2ZmLWJ5OiBDaHJpc3RvcGggQsO2aG13YWxkZXIgPGNocmlzdG9waEBib2VobXdhbGRlci5h
dD4NCj4gLS0tDQoNClRoYW5rcywgYXBwbGllZCB0byBvdXIgaW50ZXJuYWwgdHJlZS4gIEl0IHdp
bGwgZXZlbnR1YWxseSByZWFjaCB0aGUNCm1haW5saW5lLCBmb2xsb3dpbmcgb3VyIHVzdWFsIHVw
c3RyZWFtaW5nIHByb2Nlc3MuDQoNCi0tDQpDaGVlcnMsDQpMdWNhLg==