2017-11-20 12:33:55

by Venkat Prashanth B U

Subject: [PATCH] rtlwifi:rtl8723ae: Fix embedded function names with __func__ Prefer and make it generic by using %s and __func__ to print functions name instead of embedding functions name in print statements

From: Venkat Prashanth B U <[email protected]>

---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
index f713c72..bd56bb6 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
@@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,

if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error\n");
+ "%s():DMA Mapping Error", __func__);
return;
}
if (mac->opmode == NL80211_IFTYPE_STATION) {
@@ -498,7 +498,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
if (ieee80211_is_data_qos(fc)) {
if (mac->rdg_en) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "Enable RDG function.\n");
+ "%s():Enable RDG function.\n", __func__);
SET_TX_DESC_RDG_ENABLE(pdesc, 1);
SET_TX_DESC_HTC(pdesc, 1);
}
@@ -537,7 +537,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,
SET_TX_DESC_BMC(pdesc, 1);
}

- RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
+ RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "%s():\n", __func__);
}

void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,
@@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,

if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error\n");
+ "%s():DMA Mapping Error", __func__);
return;
}
CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);
--
1.9.1

2017-11-20 19:31:46

by Greg Kroah-Hartman

Subject: Re: [PATCH] rtlwifi:rtl8723ae: Fix embedded function names with __func__ Prefer and make it generic by using %s and __func__ to print functions name instead of embedding functions name in print statements

On Mon, Nov 20, 2017 at 06:03:19PM +0530, [email protected] wrote:
> From: Venkat Prashanth B U <[email protected]>
>
> ---

Something when really wrong when you created your patch :(

Please always send it to yourself first, and of course, use
scripts/checkpatch.pl to ensure you did not do anything wrong (like was
done here...)

good luck!

greg k-h