2017-12-12 13:34:48

by Venkat Prashanth B U

Subject: [PATCH] Drivers:RTLWIFI:rtl8723ae: add the function name to the printouts

From: Venkat Prashanth B U <[email protected]>

This is a patch to rtl8723ae/trx.c file that adds the
function name to the printouts.

Signed-off-by: Venkat Prashanth B U <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
index 2f7c144..96c5385 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c
@@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw,

if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error");
+ "%s():DMA mapping error", __func__);
return;
}
if (mac->opmode == NL80211_IFTYPE_STATION) {
@@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw,

if (pci_dma_mapping_error(rtlpci->pdev, mapping)) {
RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
- "DMA mapping error");
+ "%s():DMA mapping error", __func__);
return;
}
CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);
--
1.9.1

2018-01-08 16:01:26

by Kalle Valo

Subject: Re: Drivers:RTLWIFI:rtl8723ae: add the function name to the printouts

[email protected] wrote:

> From: Venkat Prashanth B U <[email protected]>
>
> This is a patch to rtl8723ae/trx.c file that adds the
> function name to the printouts.
>
> Signed-off-by: Venkat Prashanth B U <[email protected]>

The title is wrong:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

Also I would like to see an ack from Larry or other active developers before I
take something cosmetic like this.

--
https://patchwork.kernel.org/patch/10107381/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches