2018-01-26 14:21:04

by Wojciech Dubowik

[permalink] [raw]
Subject: [PATCH] ath9k: Fix get channel default noise floor

Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
when available") introduced regression in ath9k_hw_getchan_noise
where per chain nominal noise floor has been taken instead default
for channel.
Revert to original default channel noise floor.

Reported-by: Sebastian Gottschall <[email protected]>
Signed-off-by: Wojciech Dubowik <[email protected]>
---
drivers/net/wireless/ath/ath9k/calib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
index 3d9447e..695c779 100644
--- a/drivers/net/wireless/ath/ath9k/calib.c
+++ b/drivers/net/wireless/ath/ath9k/calib.c
@@ -72,7 +72,7 @@ static s16 ath9k_hw_get_default_nf(struct ath_hw *ah,
s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan,
s16 nf)
{
- s8 noise = ath9k_hw_get_default_nf(ah, chan, 0);
+ s8 noise = ATH_DEFAULT_NOISE_FLOOR;

if (nf) {
s8 delta = nf - ATH9K_NF_CAL_NOISE_THRESH -
--
2.7.4


2018-01-26 14:35:29

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Fix get channel default noise floor

Wojciech Dubowik <[email protected]> writes:

> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Reported-by: Sebastian Gottschall <[email protected]>
> Signed-off-by: Wojciech Dubowik <[email protected]>

Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")

I can add that if this passes Sebastian's tests.

And I'm planning to queue this for 4.16.

--
Kalle Valo

2018-01-26 15:06:44

by Sebastian Gottschall

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Fix get channel default noise floor

the regression has been solved with that patch. so noise floor looks
normal for me on the 9280 chipset again

Am 26.01.2018 um 15:35 schrieb Kalle Valo:
> Wojciech Dubowik <[email protected]> writes:
>
>> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
>> when available") introduced regression in ath9k_hw_getchan_noise
>> where per chain nominal noise floor has been taken instead default
>> for channel.
>> Revert to original default channel noise floor.
>>
>> Reported-by: Sebastian Gottschall <[email protected]>
>> Signed-off-by: Wojciech Dubowik <[email protected]>
> Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")
>
> I can add that if this passes Sebastian's tests.
>
> And I'm planning to queue this for 4.16.
>

--
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565

2018-01-26 14:24:24

by Sebastian Gottschall

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Fix get channel default noise floor

let me check

Am 26.01.2018 um 15:20 schrieb Wojciech Dubowik:
> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Reported-by: Sebastian Gottschall <[email protected]>
> Signed-off-by: Wojciech Dubowik <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/calib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/calib.c b/drivers/net/wireless/ath/ath9k/calib.c
> index 3d9447e..695c779 100644
> --- a/drivers/net/wireless/ath/ath9k/calib.c
> +++ b/drivers/net/wireless/ath/ath9k/calib.c
> @@ -72,7 +72,7 @@ static s16 ath9k_hw_get_default_nf(struct ath_hw *ah,
> s16 ath9k_hw_getchan_noise(struct ath_hw *ah, struct ath9k_channel *chan,
> s16 nf)
> {
> - s8 noise = ath9k_hw_get_default_nf(ah, chan, 0);
> + s8 noise = ATH_DEFAULT_NOISE_FLOOR;
>
> if (nf) {
> s8 delta = nf - ATH9K_NF_CAL_NOISE_THRESH -


--
Mit freundlichen Grüssen / Regards

Sebastian Gottschall / CTO

NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: [email protected]
Tel.: +496251-582650 / Fax: +496251-5826565

2018-02-07 14:14:53

by Kalle Valo

[permalink] [raw]
Subject: Re: ath9k: Fix get channel default noise floor

Wojciech Dubowik <[email protected]> wrote:

> Commit 8da58553cc63 ("ath9k: Use calibrated noise floor value
> when available") introduced regression in ath9k_hw_getchan_noise
> where per chain nominal noise floor has been taken instead default
> for channel.
> Revert to original default channel noise floor.
>
> Fixes: 8da58553cc63 ("ath9k: Use calibrated noise floor value when available")
> Reported-by: Sebastian Gottschall <[email protected]>
> Signed-off-by: Wojciech Dubowik <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-current branch of ath.git, thanks.

b9607de6cf22 ath9k: Fix get channel default noise floor

--
https://patchwork.kernel.org/patch/10186025/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches