2018-02-19 15:30:07

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 00/14] staging: wilc1000: fix to avoid cameCase & unnecessary parentheses

This patch series removes the issues found by checkpatch.pl script
in host_interface.c/.h file.

Ajay Singh (14):
staging: wilc1000: rename s8PowerMode & strPowerMgmtParam to avoid
camelCase
staging: wilc1000: rename strHostIfSetMulti to avoid camelCase
staging: wilc1000: rename host_int_get_assoc_res_info() parameters to
avoid camelCase
staging: wilc1000: rename pstrHostIfRemainOnChan to avoid camelCase
staging: wilc1000: rename pstrHostIfRegisterFrame to avoid camelCase
staging: wilc1000: rename strHostIfStaInactiveT to avoid camelCase
staging: wilc1000: rename pstrRcvdGnrlAsyncInfo to avoid camelCase
staging: wilc1000: rename pstrRcvdNetworkInfo to avoid camelCase
staging: wilc1000: rename functions starting with Handle_ to avoid
camelCase
staging: wilc1000: rename functions starting with TimerCB_ to avoid
camelCase
staging: wilc1000: rename ListenTimerCB to avoid camelCase
staging: wilc1000: rename GetPeriodicRSSI to avoid camelCase
staging: wilc1000: rename wilc_remove_key() parameters to avoid
camelCase
staging: wilc1000: remove Unnecessary parentheses around
'hif_set_mc->cnt'

drivers/staging/wilc1000/host_interface.c | 220 +++++++++++++++---------------
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 111 insertions(+), 111 deletions(-)

--
2.7.4


2018-02-19 15:30:31

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 07/14] staging: wilc1000: rename pstrRcvdGnrlAsyncInfo to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index f685da2..d489b27 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1319,7 +1319,7 @@ static s32 host_int_get_assoc_res_info(struct wilc_vif *vif,
u32 *rcvd_assoc_resp_info_len);

static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
- struct rcvd_async_info *pstrRcvdGnrlAsyncInfo)
+ struct rcvd_async_info *rcvd_info)
{
s32 result = 0;
u8 u8MsgType = 0;
@@ -1343,26 +1343,26 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
if (hif_drv->hif_state == HOST_IF_WAITING_CONN_RESP ||
hif_drv->hif_state == HOST_IF_CONNECTED ||
hif_drv->usr_scan_req.scan_result) {
- if (!pstrRcvdGnrlAsyncInfo->buffer ||
+ if (!rcvd_info->buffer ||
!hif_drv->usr_conn_req.conn_result) {
netdev_err(vif->ndev, "driver is null\n");
return -EINVAL;
}

- u8MsgType = pstrRcvdGnrlAsyncInfo->buffer[0];
+ u8MsgType = rcvd_info->buffer[0];

if ('I' != u8MsgType) {
netdev_err(vif->ndev, "Received Message incorrect.\n");
return -EFAULT;
}

- u8MsgID = pstrRcvdGnrlAsyncInfo->buffer[1];
- u16MsgLen = MAKE_WORD16(pstrRcvdGnrlAsyncInfo->buffer[2], pstrRcvdGnrlAsyncInfo->buffer[3]);
- u16WidID = MAKE_WORD16(pstrRcvdGnrlAsyncInfo->buffer[4], pstrRcvdGnrlAsyncInfo->buffer[5]);
- u8WidLen = pstrRcvdGnrlAsyncInfo->buffer[6];
- u8MacStatus = pstrRcvdGnrlAsyncInfo->buffer[7];
- u8MacStatusReasonCode = pstrRcvdGnrlAsyncInfo->buffer[8];
- u8MacStatusAdditionalInfo = pstrRcvdGnrlAsyncInfo->buffer[9];
+ u8MsgID = rcvd_info->buffer[1];
+ u16MsgLen = MAKE_WORD16(rcvd_info->buffer[2], rcvd_info->buffer[3]);
+ u16WidID = MAKE_WORD16(rcvd_info->buffer[4], rcvd_info->buffer[5]);
+ u8WidLen = rcvd_info->buffer[6];
+ u8MacStatus = rcvd_info->buffer[7];
+ u8MacStatusReasonCode = rcvd_info->buffer[8];
+ u8MacStatusAdditionalInfo = rcvd_info->buffer[9];
if (hif_drv->hif_state == HOST_IF_WAITING_CONN_RESP) {
u32 u32RcvdAssocRespInfoLen = 0;
struct connect_resp_info *pstrConnectRespInfo = NULL;
@@ -1519,8 +1519,8 @@ static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
}
}

- kfree(pstrRcvdGnrlAsyncInfo->buffer);
- pstrRcvdGnrlAsyncInfo->buffer = NULL;
+ kfree(rcvd_info->buffer);
+ rcvd_info->buffer = NULL;

return result;
}
--
2.7.4

2018-02-19 15:30:28

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 06/14] staging: wilc1000: rename strHostIfStaInactiveT to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index eda395d..f685da2 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1944,7 +1944,7 @@ static s32 Handle_GetStatistics(struct wilc_vif *vif,
}

static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
- struct sta_inactive_t *strHostIfStaInactiveT)
+ struct sta_inactive_t *hif_sta_inactive)
{
s32 result = 0;
u8 *stamac;
@@ -1959,7 +1959,7 @@ static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
return -ENOMEM;

stamac = wid.val;
- ether_addr_copy(stamac, strHostIfStaInactiveT->mac);
+ ether_addr_copy(stamac, hif_sta_inactive->mac);

result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
--
2.7.4

2018-02-19 15:30:52

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 13/14] staging: wilc1000: rename wilc_remove_key() parameters to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
drivers/staging/wilc1000/host_interface.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 4cbfe3b..7ddd20d 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2674,13 +2674,13 @@ static void timer_connect_cb(struct timer_list *t)
wilc_enqueue_cmd(&msg);
}

-s32 wilc_remove_key(struct host_if_drv *hif_drv, const u8 *pu8StaAddress)
+s32 wilc_remove_key(struct host_if_drv *hif_drv, const u8 *sta_addr)
{
struct wid wid;

wid.id = (u16)WID_REMOVE_KEY;
wid.type = WID_STR;
- wid.val = (s8 *)pu8StaAddress;
+ wid.val = (s8 *)sta_addr;
wid.size = 6;

return 0;
diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging/wilc1000/host_interface.h
index aa914d6..4b60b18 100644
--- a/drivers/staging/wilc1000/host_interface.h
+++ b/drivers/staging/wilc1000/host_interface.h
@@ -304,7 +304,7 @@ struct add_sta_param {
};

struct wilc_vif;
-s32 wilc_remove_key(struct host_if_drv *hWFIDrv, const u8 *pu8StaAddress);
+s32 wilc_remove_key(struct host_if_drv *hif_drv, const u8 *sta_addr);
int wilc_remove_wep_key(struct wilc_vif *vif, u8 index);
int wilc_set_wep_default_keyid(struct wilc_vif *vif, u8 index);
int wilc_add_wep_key_bss_sta(struct wilc_vif *vif, const u8 *key, u8 len,
--
2.7.4

2018-02-19 15:30:42

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 10/14] staging: wilc1000: rename functions starting with TimerCB_ to avoid camelCase

Fix "Avoid camelCase" issues found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index b861c95..6e39766 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2647,7 +2647,7 @@ static void host_if_work(struct work_struct *work)
complete(&hif_thread_comp);
}

-static void TimerCB_Scan(struct timer_list *t)
+static void timer_scan_cb(struct timer_list *t)
{
struct host_if_drv *hif_drv = from_timer(hif_drv, t, scan_timer);
struct wilc_vif *vif = hif_drv->scan_timer_vif;
@@ -2660,7 +2660,7 @@ static void TimerCB_Scan(struct timer_list *t)
wilc_enqueue_cmd(&msg);
}

-static void TimerCB_Connect(struct timer_list *t)
+static void timer_connect_cb(struct timer_list *t)
{
struct host_if_drv *hif_drv = from_timer(hif_drv, t,
connect_timer);
@@ -3385,8 +3385,8 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
mod_timer(&periodic_rssi, jiffies + msecs_to_jiffies(5000));
}

- timer_setup(&hif_drv->scan_timer, TimerCB_Scan, 0);
- timer_setup(&hif_drv->connect_timer, TimerCB_Connect, 0);
+ timer_setup(&hif_drv->scan_timer, timer_scan_cb, 0);
+ timer_setup(&hif_drv->connect_timer, timer_connect_cb, 0);
timer_setup(&hif_drv->remain_on_ch_timer, ListenTimerCB, 0);

mutex_init(&hif_drv->cfg_values_lock);
--
2.7.4

2018-02-19 15:30:17

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 03/14] staging: wilc1000: rename host_int_get_assoc_res_info() parameters to avoid camelCase

Fix "Avoid camelCase" issues reported by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index edd35b7..ec98ccd 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1314,9 +1314,9 @@ static s32 Handle_RcvdNtwrkInfo(struct wilc_vif *vif,
}

static s32 host_int_get_assoc_res_info(struct wilc_vif *vif,
- u8 *pu8AssocRespInfo,
- u32 u32MaxAssocRespInfoLen,
- u32 *pu32RcvdAssocRespInfoLen);
+ u8 *assoc_resp_info,
+ u32 max_assoc_resp_info_len,
+ u32 *rcvd_assoc_resp_info_len);

static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
struct rcvd_async_info *pstrRcvdGnrlAsyncInfo)
@@ -3080,27 +3080,27 @@ int wilc_disconnect(struct wilc_vif *vif, u16 reason_code)
}

static s32 host_int_get_assoc_res_info(struct wilc_vif *vif,
- u8 *pu8AssocRespInfo,
- u32 u32MaxAssocRespInfoLen,
- u32 *pu32RcvdAssocRespInfoLen)
+ u8 *assoc_resp_info,
+ u32 max_assoc_resp_info_len,
+ u32 *rcvd_assoc_resp_info_len)
{
s32 result = 0;
struct wid wid;

wid.id = (u16)WID_ASSOC_RES_INFO;
wid.type = WID_STR;
- wid.val = pu8AssocRespInfo;
- wid.size = u32MaxAssocRespInfoLen;
+ wid.val = assoc_resp_info;
+ wid.size = max_assoc_resp_info_len;

result = wilc_send_config_pkt(vif, GET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
if (result) {
- *pu32RcvdAssocRespInfoLen = 0;
+ *rcvd_assoc_resp_info_len = 0;
netdev_err(vif->ndev, "Failed to send association response\n");
return -EINVAL;
}

- *pu32RcvdAssocRespInfoLen = wid.size;
+ *rcvd_assoc_resp_info_len = wid.size;
return result;
}

--
2.7.4

2018-02-19 15:30:49

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 12/14] staging: wilc1000: rename GetPeriodicRSSI to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 6dd1061..4cbfe3b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -3316,7 +3316,7 @@ int wilc_hif_set_cfg(struct wilc_vif *vif,
return wilc_enqueue_cmd(&msg);
}

-static void GetPeriodicRSSI(struct timer_list *unused)
+static void get_periodic_rssi(struct timer_list *unused)
{
struct wilc_vif *vif = periodic_rssi_vif;

@@ -3381,7 +3381,7 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
}

periodic_rssi_vif = vif;
- timer_setup(&periodic_rssi, GetPeriodicRSSI, 0);
+ timer_setup(&periodic_rssi, get_periodic_rssi, 0);
mod_timer(&periodic_rssi, jiffies + msecs_to_jiffies(5000));
}

--
2.7.4

2018-02-19 15:30:10

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 01/14] staging: wilc1000: rename s8PowerMode & strPowerMgmtParam to avoid camelCase

Fix "Avoid camelCase" issues found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 5e01f6e..3dc3d2e 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2383,20 +2383,20 @@ static void ListenTimerCB(struct timer_list *t)
}

static void Handle_PowerManagement(struct wilc_vif *vif,
- struct power_mgmt_param *strPowerMgmtParam)
+ struct power_mgmt_param *pm_param)
{
s32 result = 0;
struct wid wid;
- s8 s8PowerMode;
+ s8 power_mode;

wid.id = (u16)WID_POWER_MANAGEMENT;

- if (strPowerMgmtParam->enabled)
- s8PowerMode = MIN_FAST_PS;
+ if (pm_param->enabled)
+ power_mode = MIN_FAST_PS;
else
- s8PowerMode = NO_POWERSAVE;
+ power_mode = NO_POWERSAVE;

- wid.val = &s8PowerMode;
+ wid.val = &power_mode;
wid.size = sizeof(char);

result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
--
2.7.4

2018-02-19 15:30:38

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 09/14] staging: wilc1000: rename functions starting with Handle_ to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 98 +++++++++++++++----------------
1 file changed, 49 insertions(+), 49 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 24c9a36..b861c95 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -902,7 +902,7 @@ static s32 handle_scan_done(struct wilc_vif *vif,
}

u8 wilc_connected_ssid[6] = {0};
-static s32 Handle_Connect(struct wilc_vif *vif,
+static s32 handle_connect(struct wilc_vif *vif,
struct connect_attr *pstrHostIFconnectAttr)
{
s32 result = 0;
@@ -1244,8 +1244,8 @@ static s32 handle_connect_timeout(struct wilc_vif *vif)
return result;
}

-static s32 Handle_RcvdNtwrkInfo(struct wilc_vif *vif,
- struct rcvd_net_info *rcvd_info)
+static s32 handle_rcvd_ntwrk_info(struct wilc_vif *vif,
+ struct rcvd_net_info *rcvd_info)
{
u32 i;
bool bNewNtwrkFound;
@@ -1318,8 +1318,8 @@ static s32 host_int_get_assoc_res_info(struct wilc_vif *vif,
u32 max_assoc_resp_info_len,
u32 *rcvd_assoc_resp_info_len);

-static s32 Handle_RcvdGnrlAsyncInfo(struct wilc_vif *vif,
- struct rcvd_async_info *rcvd_info)
+static s32 handle_rcvd_gnrl_async_info(struct wilc_vif *vif,
+ struct rcvd_async_info *rcvd_info)
{
s32 result = 0;
u8 u8MsgType = 0;
@@ -1777,7 +1777,7 @@ static int handle_key(struct wilc_vif *vif,
return result;
}

-static void Handle_Disconnect(struct wilc_vif *vif)
+static void handle_disconnect(struct wilc_vif *vif)
{
struct wid wid;
struct host_if_drv *hif_drv = vif->hif_drv;
@@ -1869,7 +1869,7 @@ void wilc_resolve_disconnect_aberration(struct wilc_vif *vif)
wilc_disconnect(vif, 1);
}

-static void Handle_GetRssi(struct wilc_vif *vif)
+static void handle_get_rssi(struct wilc_vif *vif)
{
s32 result = 0;
struct wid wid;
@@ -1889,8 +1889,8 @@ static void Handle_GetRssi(struct wilc_vif *vif)
complete(&vif->hif_drv->comp_get_rssi);
}

-static s32 Handle_GetStatistics(struct wilc_vif *vif,
- struct rf_info *pstrStatistics)
+static s32 handle_get_statistics(struct wilc_vif *vif,
+ struct rf_info *pstrStatistics)
{
struct wid wid_list[5];
u32 wid_cnt = 0, result = 0;
@@ -1943,8 +1943,8 @@ static s32 Handle_GetStatistics(struct wilc_vif *vif,
return 0;
}

-static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
- struct sta_inactive_t *hif_sta_inactive)
+static s32 handle_get_inactive_time(struct wilc_vif *vif,
+ struct sta_inactive_t *hif_sta_inactive)
{
s32 result = 0;
u8 *stamac;
@@ -1987,8 +1987,8 @@ static s32 Handle_Get_InActiveTime(struct wilc_vif *vif,
return result;
}

-static void Handle_AddBeacon(struct wilc_vif *vif,
- struct beacon_attr *pstrSetBeaconParam)
+static void handle_add_beacon(struct wilc_vif *vif,
+ struct beacon_attr *pstrSetBeaconParam)
{
s32 result = 0;
struct wid wid;
@@ -2040,7 +2040,7 @@ static void Handle_AddBeacon(struct wilc_vif *vif,
kfree(pstrSetBeaconParam->tail);
}

-static void Handle_DelBeacon(struct wilc_vif *vif)
+static void handle_del_beacon(struct wilc_vif *vif)
{
s32 result = 0;
struct wid wid;
@@ -2095,8 +2095,8 @@ static u32 WILC_HostIf_PackStaParam(u8 *pu8Buffer,
return cur_byte - pu8Buffer;
}

-static void Handle_AddStation(struct wilc_vif *vif,
- struct add_sta_param *pstrStationParam)
+static void handle_add_station(struct wilc_vif *vif,
+ struct add_sta_param *pstrStationParam)
{
s32 result = 0;
struct wid wid;
@@ -2164,8 +2164,8 @@ static void handle_del_all_sta(struct wilc_vif *vif,
complete(&hif_wait_response);
}

-static void Handle_DelStation(struct wilc_vif *vif,
- struct del_sta *pstrDelStaParam)
+static void handle_del_station(struct wilc_vif *vif,
+ struct del_sta *pstrDelStaParam)
{
s32 result = 0;
struct wid wid;
@@ -2192,8 +2192,8 @@ static void Handle_DelStation(struct wilc_vif *vif,
kfree(wid.val);
}

-static void Handle_EditStation(struct wilc_vif *vif,
- struct add_sta_param *pstrStationParam)
+static void handle_edit_station(struct wilc_vif *vif,
+ struct add_sta_param *pstrStationParam)
{
s32 result = 0;
struct wid wid;
@@ -2220,8 +2220,8 @@ static void Handle_EditStation(struct wilc_vif *vif,
kfree(wid.val);
}

-static int Handle_RemainOnChan(struct wilc_vif *vif,
- struct remain_ch *hif_remain_ch)
+static int handle_remain_on_chan(struct wilc_vif *vif,
+ struct remain_ch *hif_remain_ch)
{
s32 result = 0;
u8 u8remain_on_chan_flag;
@@ -2289,8 +2289,8 @@ static int Handle_RemainOnChan(struct wilc_vif *vif,
return result;
}

-static int Handle_RegisterFrame(struct wilc_vif *vif,
- struct reg_frame *hif_reg_frame)
+static int handle_register_frame(struct wilc_vif *vif,
+ struct reg_frame *hif_reg_frame)
{
s32 result = 0;
struct wid wid;
@@ -2320,8 +2320,8 @@ static int Handle_RegisterFrame(struct wilc_vif *vif,
return result;
}

-static u32 Handle_ListenStateExpired(struct wilc_vif *vif,
- struct remain_ch *hif_remain_ch)
+static u32 handle_listen_state_expired(struct wilc_vif *vif,
+ struct remain_ch *hif_remain_ch)
{
u8 u8remain_on_chan_flag;
struct wid wid;
@@ -2382,8 +2382,8 @@ static void ListenTimerCB(struct timer_list *t)
netdev_err(vif->ndev, "wilc_mq_send fail\n");
}

-static void Handle_PowerManagement(struct wilc_vif *vif,
- struct power_mgmt_param *pm_param)
+static void handle_power_management(struct wilc_vif *vif,
+ struct power_mgmt_param *pm_param)
{
s32 result = 0;
struct wid wid;
@@ -2498,16 +2498,16 @@ static void host_if_work(struct work_struct *work)
break;

case HOST_IF_MSG_CONNECT:
- Handle_Connect(msg->vif, &msg->body.con_info);
+ handle_connect(msg->vif, &msg->body.con_info);
break;

case HOST_IF_MSG_RCVD_NTWRK_INFO:
- Handle_RcvdNtwrkInfo(msg->vif, &msg->body.net_info);
+ handle_rcvd_ntwrk_info(msg->vif, &msg->body.net_info);
break;

case HOST_IF_MSG_RCVD_GNRL_ASYNC_INFO:
- Handle_RcvdGnrlAsyncInfo(msg->vif,
- &msg->body.async_info);
+ handle_rcvd_gnrl_async_info(msg->vif,
+ &msg->body.async_info);
break;

case HOST_IF_MSG_KEY:
@@ -2523,7 +2523,7 @@ static void host_if_work(struct work_struct *work)
break;

case HOST_IF_MSG_DISCONNECT:
- Handle_Disconnect(msg->vif);
+ handle_disconnect(msg->vif);
break;

case HOST_IF_MSG_RCVD_SCAN_COMPLETE:
@@ -2535,42 +2535,42 @@ static void host_if_work(struct work_struct *work)
handle_scan_done(msg->vif, SCAN_EVENT_DONE);

if (msg->vif->hif_drv->remain_on_ch_pending)
- Handle_RemainOnChan(msg->vif,
- &msg->body.remain_on_ch);
+ handle_remain_on_chan(msg->vif,
+ &msg->body.remain_on_ch);

break;

case HOST_IF_MSG_GET_RSSI:
- Handle_GetRssi(msg->vif);
+ handle_get_rssi(msg->vif);
break;

case HOST_IF_MSG_GET_STATISTICS:
- Handle_GetStatistics(msg->vif,
- (struct rf_info *)msg->body.data);
+ handle_get_statistics(msg->vif,
+ (struct rf_info *)msg->body.data);
break;

case HOST_IF_MSG_ADD_BEACON:
- Handle_AddBeacon(msg->vif, &msg->body.beacon_info);
+ handle_add_beacon(msg->vif, &msg->body.beacon_info);
break;

case HOST_IF_MSG_DEL_BEACON:
- Handle_DelBeacon(msg->vif);
+ handle_del_beacon(msg->vif);
break;

case HOST_IF_MSG_ADD_STATION:
- Handle_AddStation(msg->vif, &msg->body.add_sta_info);
+ handle_add_station(msg->vif, &msg->body.add_sta_info);
break;

case HOST_IF_MSG_DEL_STATION:
- Handle_DelStation(msg->vif, &msg->body.del_sta_info);
+ handle_del_station(msg->vif, &msg->body.del_sta_info);
break;

case HOST_IF_MSG_EDIT_STATION:
- Handle_EditStation(msg->vif, &msg->body.edit_sta_info);
+ handle_edit_station(msg->vif, &msg->body.edit_sta_info);
break;

case HOST_IF_MSG_GET_INACTIVETIME:
- Handle_Get_InActiveTime(msg->vif, &msg->body.mac_info);
+ handle_get_inactive_time(msg->vif, &msg->body.mac_info);
break;

case HOST_IF_MSG_SCAN_TIMER_FIRED:
@@ -2582,8 +2582,8 @@ static void host_if_work(struct work_struct *work)
break;

case HOST_IF_MSG_POWER_MGMT:
- Handle_PowerManagement(msg->vif,
- &msg->body.pwr_mgmt_info);
+ handle_power_management(msg->vif,
+ &msg->body.pwr_mgmt_info);
break;

case HOST_IF_MSG_SET_WFIDRV_HANDLER:
@@ -2610,15 +2610,15 @@ static void host_if_work(struct work_struct *work)
break;

case HOST_IF_MSG_REMAIN_ON_CHAN:
- Handle_RemainOnChan(msg->vif, &msg->body.remain_on_ch);
+ handle_remain_on_chan(msg->vif, &msg->body.remain_on_ch);
break;

case HOST_IF_MSG_REGISTER_FRAME:
- Handle_RegisterFrame(msg->vif, &msg->body.reg_frame);
+ handle_register_frame(msg->vif, &msg->body.reg_frame);
break;

case HOST_IF_MSG_LISTEN_TIMER_FIRED:
- Handle_ListenStateExpired(msg->vif, &msg->body.remain_on_ch);
+ handle_listen_state_expired(msg->vif, &msg->body.remain_on_ch);
break;

case HOST_IF_MSG_SET_MULTICAST_FILTER:
--
2.7.4

2018-02-19 15:30:45

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 11/14] staging: wilc1000: rename ListenTimerCB to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 6e39766..6dd1061 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2362,7 +2362,7 @@ static u32 handle_listen_state_expired(struct wilc_vif *vif,
return result;
}

-static void ListenTimerCB(struct timer_list *t)
+static void listen_timer_cb(struct timer_list *t)
{
struct host_if_drv *hif_drv = from_timer(hif_drv, t,
remain_on_ch_timer);
@@ -3387,7 +3387,7 @@ int wilc_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)

timer_setup(&hif_drv->scan_timer, timer_scan_cb, 0);
timer_setup(&hif_drv->connect_timer, timer_connect_cb, 0);
- timer_setup(&hif_drv->remain_on_ch_timer, ListenTimerCB, 0);
+ timer_setup(&hif_drv->remain_on_ch_timer, listen_timer_cb, 0);

mutex_init(&hif_drv->cfg_values_lock);
mutex_lock(&hif_drv->cfg_values_lock);
--
2.7.4

2018-02-19 15:30:14

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 02/14] staging: wilc1000: rename strHostIfSetMulti to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 3dc3d2e..edd35b7 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2406,7 +2406,7 @@ static void Handle_PowerManagement(struct wilc_vif *vif,
}

static void Handle_SetMulticastFilter(struct wilc_vif *vif,
- struct set_multicast *strHostIfSetMulti)
+ struct set_multicast *hif_set_mc)
{
s32 result = 0;
struct wid wid;
@@ -2414,25 +2414,25 @@ static void Handle_SetMulticastFilter(struct wilc_vif *vif,

wid.id = (u16)WID_SETUP_MULTICAST_FILTER;
wid.type = WID_BIN;
- wid.size = sizeof(struct set_multicast) + (strHostIfSetMulti->cnt * ETH_ALEN);
+ wid.size = sizeof(struct set_multicast) + (hif_set_mc->cnt * ETH_ALEN);
wid.val = kmalloc(wid.size, GFP_KERNEL);
if (!wid.val)
goto ERRORHANDLER;

cur_byte = wid.val;
- *cur_byte++ = (strHostIfSetMulti->enabled & 0xFF);
+ *cur_byte++ = (hif_set_mc->enabled & 0xFF);
*cur_byte++ = 0;
*cur_byte++ = 0;
*cur_byte++ = 0;

- *cur_byte++ = (strHostIfSetMulti->cnt & 0xFF);
- *cur_byte++ = ((strHostIfSetMulti->cnt >> 8) & 0xFF);
- *cur_byte++ = ((strHostIfSetMulti->cnt >> 16) & 0xFF);
- *cur_byte++ = ((strHostIfSetMulti->cnt >> 24) & 0xFF);
+ *cur_byte++ = (hif_set_mc->cnt & 0xFF);
+ *cur_byte++ = ((hif_set_mc->cnt >> 8) & 0xFF);
+ *cur_byte++ = ((hif_set_mc->cnt >> 16) & 0xFF);
+ *cur_byte++ = ((hif_set_mc->cnt >> 24) & 0xFF);

- if ((strHostIfSetMulti->cnt) > 0)
+ if ((hif_set_mc->cnt) > 0)
memcpy(cur_byte, wilc_multicast_mac_addr_list,
- ((strHostIfSetMulti->cnt) * ETH_ALEN));
+ ((hif_set_mc->cnt) * ETH_ALEN));

result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
--
2.7.4

2018-02-19 15:30:35

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 08/14] staging: wilc1000: rename pstrRcvdNetworkInfo to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index d489b27..24c9a36 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -1245,7 +1245,7 @@ static s32 handle_connect_timeout(struct wilc_vif *vif)
}

static s32 Handle_RcvdNtwrkInfo(struct wilc_vif *vif,
- struct rcvd_net_info *pstrRcvdNetworkInfo)
+ struct rcvd_net_info *rcvd_info)
{
u32 i;
bool bNewNtwrkFound;
@@ -1257,7 +1257,7 @@ static s32 Handle_RcvdNtwrkInfo(struct wilc_vif *vif,
bNewNtwrkFound = true;

if (hif_drv->usr_scan_req.scan_result) {
- wilc_parse_network_info(pstrRcvdNetworkInfo->buffer, &pstrNetworkInfo);
+ wilc_parse_network_info(rcvd_info->buffer, &pstrNetworkInfo);
if (!pstrNetworkInfo ||
!hif_drv->usr_scan_req.scan_result) {
netdev_err(vif->ndev, "driver is null\n");
@@ -1302,8 +1302,8 @@ static s32 Handle_RcvdNtwrkInfo(struct wilc_vif *vif,
}

done:
- kfree(pstrRcvdNetworkInfo->buffer);
- pstrRcvdNetworkInfo->buffer = NULL;
+ kfree(rcvd_info->buffer);
+ rcvd_info->buffer = NULL;

if (pstrNetworkInfo) {
kfree(pstrNetworkInfo->ies);
--
2.7.4

2018-02-19 15:30:24

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 05/14] staging: wilc1000: rename pstrHostIfRegisterFrame to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 11e4737..eda395d 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2290,7 +2290,7 @@ static int Handle_RemainOnChan(struct wilc_vif *vif,
}

static int Handle_RegisterFrame(struct wilc_vif *vif,
- struct reg_frame *pstrHostIfRegisterFrame)
+ struct reg_frame *hif_reg_frame)
{
s32 result = 0;
struct wid wid;
@@ -2304,9 +2304,9 @@ static int Handle_RegisterFrame(struct wilc_vif *vif,

cur_byte = wid.val;

- *cur_byte++ = pstrHostIfRegisterFrame->reg;
- *cur_byte++ = pstrHostIfRegisterFrame->reg_id;
- memcpy(cur_byte, &pstrHostIfRegisterFrame->frame_type, sizeof(u16));
+ *cur_byte++ = hif_reg_frame->reg;
+ *cur_byte++ = hif_reg_frame->reg_id;
+ memcpy(cur_byte, &hif_reg_frame->frame_type, sizeof(u16));

wid.size = sizeof(u16) + 2;

--
2.7.4

2018-02-19 15:30:56

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 14/14] staging: wilc1000: remove Unnecessary parentheses around 'hif_set_mc->cnt'

Fix "Unnecessary parentheses around 'hif_set_mc->cnt'" issue found by
checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 7ddd20d..6f93966 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2430,7 +2430,7 @@ static void Handle_SetMulticastFilter(struct wilc_vif *vif,
*cur_byte++ = ((hif_set_mc->cnt >> 16) & 0xFF);
*cur_byte++ = ((hif_set_mc->cnt >> 24) & 0xFF);

- if ((hif_set_mc->cnt) > 0)
+ if (hif_set_mc->cnt > 0)
memcpy(cur_byte, wilc_multicast_mac_addr_list,
((hif_set_mc->cnt) * ETH_ALEN));

--
2.7.4

2018-02-19 15:30:21

by Ajay Singh

[permalink] [raw]
Subject: [PATCH 04/14] staging: wilc1000: rename pstrHostIfRemainOnChan to avoid camelCase

Fix "Avoid camelCase" issue found by checkpatch.pl script.

Signed-off-by: Ajay Singh <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index ec98ccd..11e4737 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -2221,7 +2221,7 @@ static void Handle_EditStation(struct wilc_vif *vif,
}

static int Handle_RemainOnChan(struct wilc_vif *vif,
- struct remain_ch *pstrHostIfRemainOnChan)
+ struct remain_ch *hif_remain_ch)
{
s32 result = 0;
u8 u8remain_on_chan_flag;
@@ -2229,13 +2229,13 @@ static int Handle_RemainOnChan(struct wilc_vif *vif,
struct host_if_drv *hif_drv = vif->hif_drv;

if (!hif_drv->remain_on_ch_pending) {
- hif_drv->remain_on_ch.arg = pstrHostIfRemainOnChan->arg;
- hif_drv->remain_on_ch.expired = pstrHostIfRemainOnChan->expired;
- hif_drv->remain_on_ch.ready = pstrHostIfRemainOnChan->ready;
- hif_drv->remain_on_ch.ch = pstrHostIfRemainOnChan->ch;
- hif_drv->remain_on_ch.id = pstrHostIfRemainOnChan->id;
+ hif_drv->remain_on_ch.arg = hif_remain_ch->arg;
+ hif_drv->remain_on_ch.expired = hif_remain_ch->expired;
+ hif_drv->remain_on_ch.ready = hif_remain_ch->ready;
+ hif_drv->remain_on_ch.ch = hif_remain_ch->ch;
+ hif_drv->remain_on_ch.id = hif_remain_ch->id;
} else {
- pstrHostIfRemainOnChan->ch = hif_drv->remain_on_ch.ch;
+ hif_remain_ch->ch = hif_drv->remain_on_ch.ch;
}

if (hif_drv->usr_scan_req.scan_result) {
@@ -2264,7 +2264,7 @@ static int Handle_RemainOnChan(struct wilc_vif *vif,
}

wid.val[0] = u8remain_on_chan_flag;
- wid.val[1] = (s8)pstrHostIfRemainOnChan->ch;
+ wid.val[1] = (s8)hif_remain_ch->ch;

result = wilc_send_config_pkt(vif, SET_CFG, &wid, 1,
wilc_get_vif_idx(vif));
@@ -2277,7 +2277,7 @@ static int Handle_RemainOnChan(struct wilc_vif *vif,
hif_drv->remain_on_ch_timer_vif = vif;
mod_timer(&hif_drv->remain_on_ch_timer,
jiffies +
- msecs_to_jiffies(pstrHostIfRemainOnChan->duration));
+ msecs_to_jiffies(hif_remain_ch->duration));

if (hif_drv->remain_on_ch.ready)
hif_drv->remain_on_ch.ready(hif_drv->remain_on_ch.arg);
@@ -2321,7 +2321,7 @@ static int Handle_RegisterFrame(struct wilc_vif *vif,
}

static u32 Handle_ListenStateExpired(struct wilc_vif *vif,
- struct remain_ch *pstrHostIfRemainOnChan)
+ struct remain_ch *hif_remain_ch)
{
u8 u8remain_on_chan_flag;
struct wid wid;
@@ -2350,7 +2350,7 @@ static u32 Handle_ListenStateExpired(struct wilc_vif *vif,

if (hif_drv->remain_on_ch.expired) {
hif_drv->remain_on_ch.expired(hif_drv->remain_on_ch.arg,
- pstrHostIfRemainOnChan->id);
+ hif_remain_ch->id);
}
P2P_LISTEN_STATE = 0;
} else {
--
2.7.4