2018-05-15 09:22:34

by Sushant Kumar Mishra

Subject: [PATCH 1/2] rsi: add fix for crash during assertions

From: Sanjay Konduri <[email protected]>

Observed crash in some scenarios when assertion has occurred,
this is because hw structure is freed and is tried to get
accessed in some functions where null check is already
present. So, avoided the crash by making the hw to NULL after
freeing.

Signed-off-by: Sanjay Konduri <[email protected]>
Signed-off-by: Sushant Kumar Mishra <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 3faa044..bfa7569 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -245,6 +245,7 @@ void rsi_mac80211_detach(struct rsi_hw *adapter)
ieee80211_stop_queues(hw);
ieee80211_unregister_hw(hw);
ieee80211_free_hw(hw);
+ adapter->hw = NULL;
}

for (band = 0; band < NUM_NL80211_BANDS; band++) {
--
2.1.0

2018-05-23 08:02:57

by Kalle Valo

Subject: Re: [1/2] rsi: add fix for crash during assertions

Sushant Kumar Mishra <[email protected]> wrote:

> From: Sanjay Konduri <[email protected]>
>
> Observed crash in some scenarios when assertion has occurred,
> this is because hw structure is freed and is tried to get
> accessed in some functions where null check is already
> present. So, avoided the crash by making the hw to NULL after
> freeing.
>
> Signed-off-by: Sanjay Konduri <[email protected]>
> Signed-off-by: Sushant Kumar Mishra <[email protected]>

2 patches applied to wireless-drivers-next.git, thanks.

abd39c6ded9d rsi: add fix for crash during assertions
eeed833aaa38 rsi: add fix for corruption of auto rate table

--
https://patchwork.kernel.org/patch/10400687/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2018-05-15 09:22:37

by Sushant Kumar Mishra

Subject: [PATCH 2/2] rsi: add fix for corruption of auto rate table

From: Sanjay Konduri <[email protected]>

Auto rate table sent to firmware is getting corrupted
as memset to zeros is not done. Added memset to skb
data before filling auto rate table.

Signed-off-by: Sanjay Konduri <[email protected]>
Signed-off-by: Sushant Kumar Mishra <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 0757adc..d0e5937 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -1190,6 +1190,7 @@ static int rsi_send_auto_rate_request(struct rsi_common *common,
return -ENOMEM;
}

+ memset(skb->data, 0, frame_len);
selected_rates = kzalloc(2 * RSI_TBL_SZ, GFP_KERNEL);
if (!selected_rates) {
rsi_dbg(ERR_ZONE, "%s: Failed in allocation of mem\n",
--
2.1.0