2018-09-06 18:03:06

by Rakesh Pillai

Subject: [PATCH v2] ath10k: Fix tx status flag setting for management frames

The tx_status for management frames is being filled
incorrectly in the flags of skb_cb. This incorrect
flag setting causes the upper layers to consider that
the particular frame was not transmitted properly,
leading to improper behavior.

Set the IEEE80211_TX_STAT_ACK flag in the info flags
of skb_cb, to indicate the successful transmission of
the management frame.

Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1

Signed-off-by: Rakesh Pillai <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index fd612d2..1dced0d 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2336,7 +2336,12 @@ static int wmi_process_mgmt_tx_comp(struct ath10k *ar, u32 desc_id,
dma_unmap_single(ar->dev, pkt_addr->paddr,
msdu->len, DMA_FROM_DEVICE);
info = IEEE80211_SKB_CB(msdu);
- info->flags |= status;
+
+ if (status)
+ info->flags &= ~IEEE80211_TX_STAT_ACK;
+ else
+ info->flags |= IEEE80211_TX_STAT_ACK;
+
ieee80211_tx_status_irqsafe(ar->hw, msdu);

ret = 0;
--
2.7.4

2018-10-01 13:53:15

by Kalle Valo

Subject: Re: [PATCH v2] ath10k: Fix tx status flag setting for management frames

Rakesh Pillai <[email protected]> wrote:

> The tx_status for management frames is being filled
> incorrectly in the flags of skb_cb. This incorrect
> flag setting causes the upper layers to consider that
> the particular frame was not transmitted properly,
> leading to improper behavior.
>
> Set the IEEE80211_TX_STAT_ACK flag in the info flags
> of skb_cb, to indicate the successful transmission of
> the management frame.
>
> Tested HW: WCN3990
> Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1
>
> Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d
> Signed-off-by: Rakesh Pillai <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

058a7eab9d9e ath10k: fix tx status flag setting for management frames

--
https://patchwork.kernel.org/patch/10590621/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches