2018-09-11 17:17:32

by Yue Haibing

Subject: [PATCH] qtnfmac: remove set but not used variable 'vif'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
variable 'vif' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/wireless/quantenna/qtnfmac/cfg80211.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
index 4aa332f..452d4b7 100644
--- a/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
+++ b/drivers/net/wireless/quantenna/qtnfmac/cfg80211.c
@@ -691,11 +691,8 @@ static int qtnf_set_default_key(struct wiphy *wiphy, struct net_device *dev,
const struct cfg80211_chan_def *chandef = &wdev->chandef;
struct ieee80211_channel *chan;
struct qtnf_chan_stats stats;
- struct qtnf_vif *vif;
int ret;

- vif = qtnf_netdev_get_priv(dev);
-
sband = wiphy->bands[NL80211_BAND_2GHZ];
if (sband && idx >= sband->n_channels) {
idx -= sband->n_channels;

2018-09-20 17:55:44

by Kalle Valo

Subject: Re: [PATCH] qtnfmac: remove set but not used variable 'vif'

YueHaibing <[email protected]> wrote:

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
> variable 'vif' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <[email protected]>
> Reviewed-by: Sergey Matyukevich <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

93ed990e3a6e qtnfmac: remove set but not used variable 'vif'

--
https://patchwork.kernel.org/patch/10595609/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2018-09-11 17:58:28

by Sergey Matyukevich

Subject: Re: [PATCH] qtnfmac: remove set but not used variable 'vif'

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c: In function 'qtnf_dump_survey':
> drivers/net/wireless/quantenna/qtnfmac/cfg80211.c:694:19: warning:
> variable 'vif' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: YueHaibing <[email protected]>

Thanks !

Reviewed-by: Sergey Matyukevich <[email protected]>

Regards,
Sergey