2018-09-26 12:43:27

by zhong jiang

[permalink] [raw]
Subject: [PATCH v2] NFC: st-nci: remove a redundant null pointer check

The dev is impossible is NULL. hence the check is redundant. We
never will hit it.

Signed-off-by: zhong jiang <[email protected]>
---
v1->v2:
- According to Greg's suggestion. just remove the null pointer will be better.

drivers/nfc/st-nci/spi.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/nfc/st-nci/spi.c b/drivers/nfc/st-nci/spi.c
index 1470559..864fd90 100644
--- a/drivers/nfc/st-nci/spi.c
+++ b/drivers/nfc/st-nci/spi.c
@@ -233,13 +233,6 @@ static int st_nci_spi_probe(struct spi_device *dev)
dev_dbg(&dev->dev, "%s\n", __func__);
dev_dbg(&dev->dev, "IRQ: %d\n", dev->irq);

- /* Check SPI platform functionnalities */
- if (!dev) {
- pr_debug("%s: dev is NULL. Device is not accessible.\n",
- __func__);
- return -ENODEV;
- }
-
phy = devm_kzalloc(&dev->dev, sizeof(struct st_nci_spi_phy),
GFP_KERNEL);
if (!phy)
--
1.7.12.4