2018-10-23 03:40:04

by zhong jiang

Subject: [PATCH] ath9k: remove set but not used variable 'new_flags'

new_flags is not used after setting its value. It is safe to remove
the unused variable.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/net/wireless/ath/ath9k/ar9003_mci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
index 0fe9c83..9899661 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mci.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
@@ -1055,17 +1055,15 @@ void ar9003_mci_stop_bt(struct ath_hw *ah, bool save_fullsleep)
static void ar9003_mci_send_2g5g_status(struct ath_hw *ah, bool wait_done)
{
struct ath9k_hw_mci *mci = &ah->btcoex_hw.mci;
- u32 new_flags, to_set, to_clear;
+ u32 to_set, to_clear;

if (!mci->update_2g5g || (mci->bt_state == MCI_BT_SLEEP))
return;

if (mci->is_2g) {
- new_flags = MCI_2G_FLAGS;
to_clear = MCI_2G_FLAGS_CLEAR_MASK;
to_set = MCI_2G_FLAGS_SET_MASK;
} else {
- new_flags = MCI_5G_FLAGS;
to_clear = MCI_5G_FLAGS_CLEAR_MASK;
to_set = MCI_5G_FLAGS_SET_MASK;
}
--
1.7.12.4

2018-11-05 11:19:06

by Kalle Valo

Subject: Re: [PATCH] ath9k: remove set but not used variable 'new_flags'

zhong jiang <[email protected]> wrote:

> new_flags is not used after setting its value. It is safe to remove
> the unused variable.
>
> Signed-off-by: zhong jiang <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

53d76f1687ba ath9k: remove set but not used variable 'new_flags'

--
https://patchwork.kernel.org/patch/10652679/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches