2018-11-05 11:25:37

by Zhangshaokun

Subject: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information

RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
prefix, which is somewhat misleading.

Fix it to print hexadecimal, as was intended.

Cc: Ping-Ke Shih <[email protected]>
Cc: Kalle Valo <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
index 85cedd0..75bfa9d 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
@@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw)
rtl_read_byte(rtlpriv, FW_MAC1_READY));
}
RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
- "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n",
+ "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n",
rtl_read_dword(rtlpriv, REG_MCUFWDL));
return -1;
}
--
2.7.4

2018-11-06 01:57:21

by Ping-Ke Shih

Subject: Re: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information

On Mon, 2018-11-05 at 19:25 +0800, Shaokun Zhang wrote:
> RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Cc: Ping-Ke Shih <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> index 85cedd0..75bfa9d 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/fw.c
> @@ -173,7 +173,7 @@ static int _rtl92d_fw_init(struct ieee80211_hw *hw)
>    rtl_read_byte(rtlpriv, FW_MAC1_READY));
>   }
>   RT_TRACE(rtlpriv, COMP_FW, DBG_DMESG,
> -  "Polling FW ready fail!! REG_MCUFWDL:0x%08ul\n",
> +  "Polling FW ready fail!! REG_MCUFWDL:0x%08x\n",
>    rtl_read_dword(rtlpriv, REG_MCUFWDL));
>   return -1;
>  }

Acked-by: Ping-Ke Shih <[email protected]>

Thanks for your fix.

2018-11-06 17:05:18

by Kalle Valo

Subject: Re: [PATCH] rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information

Shaokun Zhang <[email protected]> wrote:

> RT_TRACE shows REG_MCUFWDL value as a decimal value with a '0x'
> prefix, which is somewhat misleading.
>
> Fix it to print hexadecimal, as was intended.
>
> Cc: Ping-Ke Shih <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> Acked-by: Ping-Ke Shih <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

7d129adff3af rtlwifi: rtl8192de: Fix misleading REG_MCUFWDL information

--
https://patchwork.kernel.org/patch/10667863/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches