Subject: [PATCH] drivers: net: wireless: rsi: return explicit error values

From: Enrico Weigelt <[email protected]>

Explicitly return constants instead of variable (and rely on
it to be explicitly initialized), if the value is supposed
to be fixed anyways. Align it with the rest of the driver,
which does it the same way.

Signed-off-by: Enrico Weigelt <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_sdio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_sdio.c b/drivers/net/wireless/rsi/rsi_91x_sdio.c
index b42cd50..2a3577d 100644
--- a/drivers/net/wireless/rsi/rsi_91x_sdio.c
+++ b/drivers/net/wireless/rsi/rsi_91x_sdio.c
@@ -844,11 +844,11 @@ static int rsi_init_sdio_interface(struct rsi_hw *adapter,
struct sdio_func *pfunction)
{
struct rsi_91x_sdiodev *rsi_91x_dev;
- int status = -ENOMEM;
+ int status;

rsi_91x_dev = kzalloc(sizeof(*rsi_91x_dev), GFP_KERNEL);
if (!rsi_91x_dev)
- return status;
+ return -ENOMEM;

adapter->rsi_dev = rsi_91x_dev;

@@ -890,7 +890,7 @@ static int rsi_init_sdio_interface(struct rsi_hw *adapter,
#ifdef CONFIG_RSI_DEBUGFS
adapter->num_debugfs_entries = MAX_DEBUGFS_ENTRIES;
#endif
- return status;
+ return 0;
fail:
sdio_disable_func(pfunction);
sdio_release_host(pfunction);
--
1.9.1


2019-07-30 11:07:51

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] drivers: net: wireless: rsi: return explicit error values

"Enrico Weigelt, metux IT consult" <[email protected]> writes:

> From: Enrico Weigelt <[email protected]>
>
> Explicitly return constants instead of variable (and rely on
> it to be explicitly initialized), if the value is supposed
> to be fixed anyways. Align it with the rest of the driver,
> which does it the same way.
>
> Signed-off-by: Enrico Weigelt <[email protected]>
> ---
> drivers/net/wireless/rsi/rsi_91x_sdio.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

The prefix should be just "rsi:", I'll fix that.

--
Kalle Valo

2019-08-06 12:42:04

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] rsi: return explicit error values

"Enrico Weigelt, metux IT consult" <[email protected]> wrote:

> From: Enrico Weigelt <[email protected]>
>
> Explicitly return constants instead of variable (and rely on
> it to be explicitly initialized), if the value is supposed
> to be fixed anyways. Align it with the rest of the driver,
> which does it the same way.
>
> Signed-off-by: Enrico Weigelt <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

706f0182b1ad rt2800usb: Add new rt2800usb device PLANEX GW-USMicroN

--
https://patchwork.kernel.org/patch/11064039/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches