2019-09-12 18:51:08

by zhong jiang

Subject: [PATCH 3/3] libertas: Remove unneeded variable and make function to be void

lbs_process_event do not need return value to cope with different
cases. And change functon return type to void.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/net/wireless/marvell/libertas/cmd.h | 2 +-
drivers/net/wireless/marvell/libertas/cmdresp.c | 5 +----
2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/marvell/libertas/cmd.h b/drivers/net/wireless/marvell/libertas/cmd.h
index 8087856..3c19307 100644
--- a/drivers/net/wireless/marvell/libertas/cmd.h
+++ b/drivers/net/wireless/marvell/libertas/cmd.h
@@ -76,7 +76,7 @@ void lbs_mac_event_disconnected(struct lbs_private *priv,

/* Events */

-int lbs_process_event(struct lbs_private *priv, u32 event);
+void lbs_process_event(struct lbs_private *priv, u32 event);


/* Actual commands */
diff --git a/drivers/net/wireless/marvell/libertas/cmdresp.c b/drivers/net/wireless/marvell/libertas/cmdresp.c
index b73d083..cb515c5 100644
--- a/drivers/net/wireless/marvell/libertas/cmdresp.c
+++ b/drivers/net/wireless/marvell/libertas/cmdresp.c
@@ -220,9 +220,8 @@ int lbs_process_command_response(struct lbs_private *priv, u8 *data, u32 len)
return ret;
}

-int lbs_process_event(struct lbs_private *priv, u32 event)
+void lbs_process_event(struct lbs_private *priv, u32 event)
{
- int ret = 0;
struct cmd_header cmd;

switch (event) {
@@ -351,6 +350,4 @@ int lbs_process_event(struct lbs_private *priv, u32 event)
netdev_alert(priv->dev, "EVENT: unknown event id %d\n", event);
break;
}
-
- return ret;
}
--
1.7.12.4

2019-09-13 13:39:01

by Kalle Valo

Subject: Re: [PATCH 3/3] libertas: Remove unneeded variable and make function to be void

zhong jiang <[email protected]> wrote:

> lbs_process_event do not need return value to cope with different
> cases. And change functon return type to void.
>
> Signed-off-by: zhong jiang <[email protected]>

Same here, I just don't see the benefit.

Patch set to Rejected.

--
https://patchwork.kernel.org/patch/11143397/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches