2017-08-08 16:04:55

by Arvind Yadav

Subject: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
index 55198ac2..121b94f 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c
@@ -43,7 +43,7 @@ MODULE_AUTHOR("Larry Finger <[email protected]>");
MODULE_DESCRIPTION("RTL8187/RTL8187B USB wireless driver");
MODULE_LICENSE("GPL");

-static struct usb_device_id rtl8187_table[] = {
+static const struct usb_device_id rtl8187_table[] = {
/* Asus */
{USB_DEVICE(0x0b05, 0x171d), .driver_info = DEVICE_RTL8187},
/* Belkin */
--
2.7.4

2017-08-25 21:05:31

by Hin-Tak Leung

Subject: Re: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id

--------------------------------------------
On Tue, 8/8/17, Arvind Yadav <[email protected]> wrote:

Subject: [PATCH 31/35] wireless: realtek: rtl8187: constify usb_device_id
To: [email protected], [email protected], [email protected], [email protected]
Cc: [email protected], [email protected], [email protected]
Date: Tuesday, 8 August, 2017, 17:04

> usb_device_id are not supposed to change at
> runtime. All functions
> working with usb_device_id provided by
> <linux/usb.h> work with
> const usb_device_id. So mark the
> non-const structs as const.

> Signed-off-by: Arvind Yadav <[email protected]>

Acked-by: [email protected]