> -----Original Message-----
> From: Ruan Jinjie <[email protected]>
> Sent: Friday, August 4, 2023 11:54 AM
> To: [email protected]; [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]
> Subject: [PATCH -next 1/6] net: thunderx: Remove unnecessary ternary operators
>
> Ther are a little ternary operators, the true or false judgement
> of which is unnecessary in C language semantics.
>
> Signed-off-by: Ruan Jinjie <[email protected]>
> ---
> drivers/net/ethernet/cavium/thunder/nic_main.c | 2 +-
> drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/nic_main.c
> b/drivers/net/ethernet/cavium/thunder/nic_main.c
> index 0ec65ec634df..b7cf4ba89b7c 100644
> --- a/drivers/net/ethernet/cavium/thunder/nic_main.c
> +++ b/drivers/net/ethernet/cavium/thunder/nic_main.c
> @@ -174,7 +174,7 @@ static void nic_mbx_send_ready(struct nicpf *nic, int vf)
> if (mac)
> ether_addr_copy((u8 *)&mbx.nic_cfg.mac_addr, mac);
> }
> - mbx.nic_cfg.sqs_mode = (vf >= nic->num_vf_en) ? true : false;
> + mbx.nic_cfg.sqs_mode = vf >= nic->num_vf_en;
> mbx.nic_cfg.node_id = nic->node;
>
> mbx.nic_cfg.loopback_supported = vf < nic->num_vf_en;
> diff --git a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> index a317feb8decb..9e467cecc33a 100644
> --- a/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> +++ b/drivers/net/ethernet/cavium/thunder/thunder_bgx.c
> @@ -957,7 +957,7 @@ static void bgx_poll_for_sgmii_link(struct lmac *lmac)
> goto next_poll;
> }
>
> - lmac->link_up = ((pcs_link & PCS_MRX_STATUS_LINK) != 0) ? true : false;
> + lmac->link_up = (pcs_link & PCS_MRX_STATUS_LINK) != 0;
lmac->link_up = !!(pcs_link & PCS_MRX_STATUS_LINK);
> an_result = bgx_reg_read(lmac->bgx, lmac->lmacid,
> BGX_GMP_PCS_ANX_AN_RESULTS);
>
> --
> 2.34.1
>
>
> ------Please consider the environment before printing this e-mail.